Develop test#1830: taking latest release changes to develop

[nagendra0721]

mosip/commons#1830

Summary by CodeRabbit

• Chores

  • Bumped project version to 1.4.0-SNAPSHOT and aligned related dependency versions
  • Updated license/NOTICE attributions for BSD/EPL-licensed components

• Configuration

  • Helm chart: switched container image repository, adjusted resource defaults, and added Prometheus metrics endpoint path

• Documentation

  • Added service documentation describing purpose, architecture, setup, and integrations

[coderabbitai]

Warning

Review limit reached

@nagendra0721, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 1 second. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07084c39-22af-4ce8-b8ad-959804d6c5bc

📥 Commits

Reviewing files that changed from the base of the PR and between 25f1501 and 390fa65.

📒 Files selected for processing (2)

• README.md
• pom.xml

Walkthrough

Updated project version to 1.4.0-SNAPSHOT with corresponding kernel dependency bumps. Migrated timestamp generation across the codebase from local DateUtils to kernel DateUtils2. Updated Helm deployment configuration with image repository, resource settings, and Prometheus metrics endpoint. Expanded license attribution documentation and added AGENTS.md.

Changes

Unified Version Update and DateUtils Migration

Layer / File(s)	Summary
Maven build configuration and dependency versions pom.xml	Project version bumped to 1.4.0-SNAPSHOT; kernel BOM versions updated; Mockito configuration consolidated to a shared mockito.version (4.11.0) with test dependencyManagement entries; maven-deploy-plugin configured to skip deployment.
DateUtils2 migration in core service implementations src/main/java/io/mosip/print/service/impl/PrintServiceImpl.java, src/main/java/io/mosip/print/service/impl/UinCardGeneratorImpl.java	PrintServiceImpl and UinCardGeneratorImpl switched to DateUtils2 from io.mosip.kernel.core.util for UTC timestamp generation in printStatusUpdate and generateUinCard. Imports reorganized and timestamp method calls updated.
DateUtils2 migration in utility and handler classes src/main/java/io/mosip/print/util/AuditLogRequestBuilder.java, src/main/java/io/mosip/print/util/DigitalSignatureUtility.java, src/main/java/io/mosip/print/util/PrintExceptionHandler.java, src/main/java/io/mosip/print/util/TokenHandlerUtil.java	AuditLogRequestBuilder, DigitalSignatureUtility, PrintExceptionHandler, and TokenHandlerUtil migrated to DateUtils2 for timestamp generation, parsing, and JWT expiration validation using corresponding DateUtils2 methods.
Test mock updates for DateUtils2 src/test/java/io/mosip/print/util/PrintExceptionHandlerTest.java	Test updated to import and mock DateUtils2 instead of DateUtils; CURRENT_DATETIME test constant changed to 2026-06-05T11:19:48.774Z with corresponding static mock configuration.
Deployment configuration and documentation updates helm/print/values.yaml, helm/print/templates/deployment.yaml, NOTICE, AGENTS.md, .github/workflows/push-trigger.yml, src/main/resources/bootstrap.properties	Helm values reorganized; image repository set to mosipid/print; Java memory options and resource requests updated; extraEnvVarsSecret wiring changed; metrics.endpointPath added; deployment template envFrom secretRef rendering updated; NOTICE expanded with Jakarta Persistence API and H2 Database attributions; AGENTS.md added; minor workflow and bootstrap edits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I hop through diffs with eager paws,
Swapping DateUtils for kernel laws,
Version bumped and Helm set right,
Notices tidy, docs alight,
A tiny rabbit, coding applause. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to bringing latest release changes to develop branch for issue #1830, which aligns with the actual changes (version bumps from 1.2.1 to 1.4.0, dependency updates, image repository changes, and documentation additions).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nagendra0721]

#1830

[coderabbitai]

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

pom.xml (1)

495-503: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Remove duplicate maven-javadoc-plugin declaration.

The maven-javadoc-plugin is already declared at lines 425-441. This duplicate declaration at line 495 causes Maven build warnings and should be removed.

🧹 Proposed fix

 			</plugin>
-			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-javadoc-plugin</artifactId>
-				<version>${maven.javadoc.version}</version>
-				<configuration>
-					<aggregate>true</aggregate>
-					<doclint>none</doclint>
-				</configuration>
-			</plugin>
 			<plugin>
 				<groupId>org.sonatype.central</groupId>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pom.xml` around lines 495 - 503, The pom contains a duplicate
maven-javadoc-plugin declaration (groupId org.apache.maven.plugins, artifactId
maven-javadoc-plugin) — locate the second declaration in the POM (the block that
sets <aggregate>true</aggregate> and <doclint>none</doclint>) and remove that
duplicate plugin element so only the original plugin declaration remains; ensure
no other plugin entries are accidentally removed and run a quick mvn validate to
confirm warnings are gone.

src/test/java/io/mosip/print/util/PrintExceptionHandlerTest.java (1)

117-480: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Complete the DateUtils2 migration in all test methods.

Only the first test method (regPrintAppExceptionHandlerShouldReturnProperResponse) was updated to mock DateUtils2. The remaining test methods at lines 117, 144, 171, 199, 226, 254, 283, 310, 339, 366, 394, 420, 447, and 474 still mock the old DateUtils.class. This inconsistency will cause test failures since the production code now uses DateUtils2.

🔧 Example fix for one test method

     `@Test`
     void pdfGeneratorExceptionHandlerShouldReturnProperResponse() {
         PDFGeneratorException exception = new PDFGeneratorException(
                 PlatformErrorMessages.PRT_PIS_IDENTITY_NOT_FOUND.getCode(),
                 PlatformErrorMessages.PRT_PIS_IDENTITY_NOT_FOUND.getMessage(),
                 new RuntimeException("PDF generation error"));
 
-        try (MockedStatic<DateUtils> dateUtilsMock = mockStatic(DateUtils.class);
+        try (MockedStatic<DateUtils2> dateUtilsMock = mockStatic(DateUtils2.class);
              MockedStatic<PrintLogger> printLoggerMock = mockStatic(PrintLogger.class)) {
 
             Logger mockLogger = mock(Logger.class);
             printLoggerMock.when(() -> PrintLogger.getLogger(PrintExceptionHandler.class))
                     .thenReturn(mockLogger);
-            dateUtilsMock.when(() -> DateUtils.getUTCCurrentDateTimeString(DATETIME_PATTERN))
+            dateUtilsMock.when(() -> DateUtils2.getUTCCurrentDateTimeString(DATETIME_PATTERN))
                     .thenReturn(CURRENT_DATETIME);

Apply this pattern to all remaining test methods in this file.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/test/java/io/mosip/print/util/PrintExceptionHandlerTest.java` around
lines 117 - 480, The tests in PrintExceptionHandlerTest still mock DateUtils
(mockStatic(DateUtils.class)) while production was migrated to DateUtils2;
update every test that currently calls mockStatic(DateUtils.class) to
mockStatic(DateUtils2.class) (including the occurrences inside methods like
templateFailureExceptionHandlerShouldReturnProperResponse,
jsonMappingExceptionHandlerShouldReturnBadRequestResponse,
invalidFormatExceptionHandlerShouldReturnBadRequestResponse,
jsonParseExceptionHandlerShouldReturnBadRequestResponse,
methodArgumentNotValidExceptionHandlerShouldReturnBadRequestResponse,
accessDeniedExceptionHandlerShouldReturnProperResponse,
invalidTokenExceptionHandlerShouldReturnProperResponse,
pdfSignatureExceptionHandlerShouldReturnProperResponse,
buildPrintApiExceptionResponseWithBaseCheckedExceptionShouldHandleCorrectly,
buildPrintApiExceptionResponseWithBaseUncheckedExceptionShouldHandleCorrectly,
buildPrintApiExceptionResponseWithNullIdShouldSetDefaultId,
buildPrintApiExceptionResponseWithMultipleErrorsShouldHandleCorrectly,
buildPrintApiExceptionResponseWithExistingIdShouldPreserveId) and ensure the
mocked call to DateUtils.getUTCCurrentDateTimeString(DATETIME_PATTERN) now
targets DateUtils2 so date mocks use CURRENT_DATETIME consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@helm/print/values.yaml`:
- Around line 119-124: The memory request (memory: 1800Mi) in values.yaml is too
low for the configured JVM max heap (javaOpts: "-Xms1350M -Xmx2250M"); either
raise the Kubernetes memory request under the resources block to cover heap +
20–30% overhead (e.g., ~2800Mi) to match Xmx, or reduce the Xmx/Xms in
additionalResources.javaOpts to fit within the current 1800Mi request — update
the memory value or the javaOpts string accordingly and keep cpu and limit
settings consistent.

In `@pom.xml`:
- Around line 90-96: The pom imports io.mosip.kernel:kernel-bom using the
property kernel.core.version (set to 1.4.0-SNAPSHOT) which cannot be resolved;
confirm and fix the Maven repository configuration or the version: check the
<repositories> / snapshots-repo entry used by the build, ensure the repository
URL and credentials allow SNAPSHOT retrieval, or change the kernel.core.version
to a published non-SNAPSHOT release; update either the repository
URL/credentials for snapshots or replace kernel-bom:1.4.0-SNAPSHOT with a
resolvable version so dependency resolution succeeds.
- Line 65: Remove the duplicate XML property declaration for
central.publishing.maven.plugin.version: locate the duplicate
<central.publishing.maven.plugin.version> element (the second occurrence) and
delete that entire property element so only the original declaration remains
(keep the first/earlier declaration and remove the later duplicate).

In `@src/main/java/io/mosip/print/service/impl/PrintServiceImpl.java`:
- Line 35: Update the tests to mock the new DateUtils2 usage: replace mocks of
DateUtils with mocks/stubs for DateUtils2.getUTCCurrentDateTime() in
PrintServiceImplTest (affecting the spots around the tests that call
generateCard()), and any other tests that currently mock DateUtils; ensure
PrintServiceImpl.printStatusUpdate() will receive the mocked UTC time by
stubbing DateUtils2.getUTCCurrentDateTime() before generateCard() is invoked so
the unmocked call no longer causes failures.

---

Outside diff comments:
In `@pom.xml`:
- Around line 495-503: The pom contains a duplicate maven-javadoc-plugin
declaration (groupId org.apache.maven.plugins, artifactId maven-javadoc-plugin)
— locate the second declaration in the POM (the block that sets
<aggregate>true</aggregate> and <doclint>none</doclint>) and remove that
duplicate plugin element so only the original plugin declaration remains; ensure
no other plugin entries are accidentally removed and run a quick mvn validate to
confirm warnings are gone.

In `@src/test/java/io/mosip/print/util/PrintExceptionHandlerTest.java`:
- Around line 117-480: The tests in PrintExceptionHandlerTest still mock
DateUtils (mockStatic(DateUtils.class)) while production was migrated to
DateUtils2; update every test that currently calls mockStatic(DateUtils.class)
to mockStatic(DateUtils2.class) (including the occurrences inside methods like
templateFailureExceptionHandlerShouldReturnProperResponse,
jsonMappingExceptionHandlerShouldReturnBadRequestResponse,
invalidFormatExceptionHandlerShouldReturnBadRequestResponse,
jsonParseExceptionHandlerShouldReturnBadRequestResponse,
methodArgumentNotValidExceptionHandlerShouldReturnBadRequestResponse,
accessDeniedExceptionHandlerShouldReturnProperResponse,
invalidTokenExceptionHandlerShouldReturnProperResponse,
pdfSignatureExceptionHandlerShouldReturnProperResponse,
buildPrintApiExceptionResponseWithBaseCheckedExceptionShouldHandleCorrectly,
buildPrintApiExceptionResponseWithBaseUncheckedExceptionShouldHandleCorrectly,
buildPrintApiExceptionResponseWithNullIdShouldSetDefaultId,
buildPrintApiExceptionResponseWithMultipleErrorsShouldHandleCorrectly,
buildPrintApiExceptionResponseWithExistingIdShouldPreserveId) and ensure the
mocked call to DateUtils.getUTCCurrentDateTimeString(DATETIME_PATTERN) now
targets DateUtils2 so date mocks use CURRENT_DATETIME consistently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 267ecc87-96c0-4fc0-b1e5-085f6b6006e4

📥 Commits

Reviewing files that changed from the base of the PR and between 31b04f0 and 7aced28.

📒 Files selected for processing (10)

• NOTICE
• helm/print/values.yaml
• pom.xml
• src/main/java/io/mosip/print/service/impl/PrintServiceImpl.java
• src/main/java/io/mosip/print/service/impl/UinCardGeneratorImpl.java
• src/main/java/io/mosip/print/util/AuditLogRequestBuilder.java
• src/main/java/io/mosip/print/util/DigitalSignatureUtility.java
• src/main/java/io/mosip/print/util/PrintExceptionHandler.java
• src/main/java/io/mosip/print/util/TokenHandlerUtil.java
• src/test/java/io/mosip/print/util/PrintExceptionHandlerTest.java

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@AGENTS.md`:
- Line 28: The markdown has lint errors in AGENTS.md: fix the malformed table
row(s) and inconsistent fenced code block languages by ensuring table pipes are
properly escaped or the row is converted to valid markdown table format (e.g.,
add surrounding pipes and consistent column count for the "PDF generation |
pdfbox" row and the other affected rows) and normalize fenced code blocks to use
a valid language hint (e.g., ```text) with matching opening and closing
backticks; update occurrences noted (around the PDF generation row and lines ~41
and ~173) so the markdown linter passes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 99a84e59-eabd-4d04-ba8a-eda8f44e5bef

📥 Commits

Reviewing files that changed from the base of the PR and between 7aced28 and 25f1501.

📒 Files selected for processing (5)

• .github/workflows/push-trigger.yml
• AGENTS.md
• helm/print/templates/deployment.yaml
• helm/print/values.yaml
• src/main/resources/bootstrap.properties

💤 Files with no reviewable changes (1)

• .github/workflows/push-trigger.yml

✅ Files skipped from review due to trivial changes (1)

• src/main/resources/bootstrap.properties

🚧 Files skipped from review as they are similar to previous changes (1)

• helm/print/values.yaml