Add triggers for new addons and metadata change to submit to Cinder#24662
Merged
eviljeff merged 3 commits intomozilla:masterfrom Mar 30, 2026
Merged
Conversation
eviljeff
commented
Mar 26, 2026
273f72d to
a56003c
Compare
a56003c to
3dc86e1
Compare
eviljeff
commented
Mar 27, 2026
| addon=addon, defaults={'last_content_review': None} | ||
| addon=addon, | ||
| defaults=defaults, | ||
| create_defaults={**defaults, 'content_review_status': not_reviewed_status}, |
Member
Author
There was a problem hiding this comment.
note, create_defaults is a django52 addition. If we decide to rollback to django42 it will need rewriting first.
diox
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15972
Description
Adds a trigger in watch_status to send an event to Cinder to carry about a content review the first time the addon status is valid; and adds further triggers in the two places you can edit metadata, and we reset content review status already.
Context
If you process the job in Cinder, the payload won't be accepted at this point, because it will refer to a job we don't know about (we can address the changes to the webhook handler in mozilla/addons#15973).
We don't make any attempt to stop the existing content review queue in reviewer tools from being populated with the add-ons too (I did investigate this, but it was non-trivial because it's all queries based on statuses, so we have to duplicate a bunch of the statuses); and if an add-on is content reviewed in the reviewer tools it won't remove the job from the Cinder queue, so it would be reviewed twice, possibly with different actions (this is particularly difficult to address, because we don't know about the job). If we don't want to support both Cinder and reviewer tools being used simultaneously (and in mozilla/addons#16106 we concluded we don't), and are planning to remove the reviewer tools content review queue anyway, this is fine.
Testing
content-review-in-cinderwaffle switch (you might need to manually run migrate)Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.