Skip to content

Validate target pid matches trusted client pid when promoting threads on Linux #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinetiknz merged 1 commit into from
Apr 22, 2026
Merged

Validate target pid matches trusted client pid when promoting threads on Linux #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion audioipc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ memmap2 = "0.9"
arrayvec = "0.7"

[target.'cfg(target_os = "linux")'.dependencies.audio_thread_priority]
version = "0.34"
version = "0.35"
default-features = false

[target.'cfg(windows)'.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ edition = "2018"
audioipc = { package = "audioipc2", path = "../audioipc" }
cubeb-backend = "0.32"
log = "0.4"
audio_thread_priority = { version = "0.34", default-features = false }
audio_thread_priority = { version = "0.35", default-features = false }
2 changes: 1 addition & 1 deletion server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ cubeb-core = "0.32"
once_cell = "1.2.0"
log = "0.4"
slab = "0.4"
audio_thread_priority = { version = "0.34", default-features = false }
audio_thread_priority = { version = "0.35", default-features = false }

20 changes: 14 additions & 6 deletions server/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,12 +677,20 @@ impl CubebServer {
#[cfg(target_os = "linux")]
ServerMessage::PromoteThreadToRealTime(thread_info) => {
let info = RtPriorityThreadInfo::deserialize(thread_info);
match promote_thread_to_real_time(info, 0, 48000) {
Ok(_) => {
info!("Promotion of content process thread to real-time OK");
}
Err(_) => {
warn!("Promotion of content process thread to real-time error");
if info.pid() as u32 != self.remote_pid.unwrap() {
warn!(
"PromoteThreadToRealTime: client supplied pid {} doesn't match trusted pid {}",
info.pid(),
self.remote_pid.unwrap()
);
} else {
match promote_thread_to_real_time(info, 0, 48000) {
Ok(_) => {
info!("Promotion of content process thread to real-time OK");
}
Err(_) => {
warn!("Promotion of content process thread to real-time error");
}
}
}
ClientMessage::ThreadPromoted
Expand Down
Loading