Added threading#5508
Open
wassafshahzad wants to merge 4 commits into
Open
Conversation
suhaibmujahid
requested changes
Dec 9, 2025
Member
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
Thank you for taking care of this, and sorry for the late review! Please take a look at my comments.
Collaborator
|
@wassafshahzad still want to finish this up or should we close the PR? |
Contributor
Author
Ohh sorry this drowned in he nitifications. I will finisn tgis is week |
Contributor
Author
|
@marco-c @suhaibmujahid I have addressed the feedback and also fixed a typing issue in util.py |
suhaibmujahid
approved these changes
May 28, 2026
Member
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
@wassafshahzad LGTM! Could you please resolve the merge conflict so we can land it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added threading to generate diff to make it run concurrently,. The design is same retrieve_logs. The only difference is that we returen a tuple (mapping_erros, diff_errors) and add them in the end for the total.
Linked PRS
Closes #5400