chore: Bump quinn-udp to 0.5.5#2107
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
|
I would like to hold back here for now. Larger context posted on Matrix:
The only relevant fix of (Note, given that it is a patch release, I can update |
|
We can definitely hold back here. Thanks for the background! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
- Coverage 95.35% 95.35% -0.01%
==========================================
Files 112 112
Lines 36325 36325
==========================================
- Hits 34638 34637 -1
- Misses 1687 1688 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 0b106c2. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.262 ns 99.600 ns 99.967 ns]
change: [-0.4834% +0.1321% +0.6536%] (p = 0.67 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.37 ns 117.77 ns 118.19 ns]
change: [-0.0167% +0.4792% +1.0002%] (p = 0.06 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.78 ns 117.19 ns 117.70 ns]
change: [-0.1247% +0.6974% +1.7956%] (p = 0.15 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.327 ns 97.445 ns 97.582 ns]
change: [-1.3123% -0.5102% +0.2133%] (p = 0.21 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.76 ms 111.81 ms 111.86 ms]
change: [+0.3179% +0.3878% +0.4561%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.794 ms 26.883 ms 27.961 ms]
change: [-9.0898% -4.1188% +1.1104%] (p = 0.13 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.263 ms 36.011 ms 37.816 ms]
change: [-7.1292% -0.4220% +6.3358%] (p = 0.89 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [30.910 ms 31.775 ms 32.603 ms]
change: [-6.3582% -2.9567% +0.3754%] (p = 0.09 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [38.850 ms 41.687 ms 44.546 ms]
change: [-17.188% -8.3531% +1.0388%] (p = 0.08 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [113.39 ms 113.83 ms 114.27 ms]
thrpt: [875.14 MiB/s 878.49 MiB/s 881.91 MiB/s]
change:
time: [-1.5799% -1.0621% -0.5212%] (p = 0.00 < 0.05)
thrpt: [+0.5239% +1.0735% +1.6052%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: 💔 Performance has regressed. time: [323.81 ms 326.90 ms 330.00 ms]
thrpt: [30.303 Kelem/s 30.590 Kelem/s 30.882 Kelem/s]
change:
time: [+1.1660% +2.6251% +4.2072%] (p = 0.00 < 0.05)
thrpt: [-4.0373% -2.5580% -1.1526%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [33.491 ms 33.656 ms 33.830 ms]
thrpt: [29.560 elem/s 29.712 elem/s 29.859 elem/s]
change:
time: [-2.2615% -1.4308% -0.6364%] (p = 0.00 < 0.05)
thrpt: [+0.6405% +1.4515% +2.3138%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
Closing here in favor of #2209. |
2 participants
No description provided.