refactor: pass now to qlog#2212
Closed
mxinden wants to merge 1 commit into
Closed
Conversation
Instead of using `QLogStream::add_event_data_now`, which internally calls `std::time::Instant::now()`, pass `now to `QLogStream::add_event_data_with_instant`.
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Collaborator
|
Probably a stupid idea, but can we make |
Member
Author
We could use a thread-local atomic. That said, I think the current approach on I am reluctant to give up the above properties for #2211 alone. Instead of this pull request, or a thread local variable, I suggest we go with #2216. |
Member
Author
|
Closing here in favor of #2216. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
QLogStream::add_event_data_now, which internally callsstd::time::Instant::now(), passnowtoQLogStream::add_event_data_with_instant.This would close #2211. That said, given that this change is very noisy, passing
nowacross all layers and addingnowto many of our public APIs (seeneqo-bin/srcfor examples), I don't think it is worth it.Let me know if you think otherwise.
Alternative: We could only do this change in
neqo-transport, having allneqo-http3functions callingneqo-transportfunctions with a freshstd::time::Instant::now(). That would give us proper qlogs when usingtest_fixtures::Simulatoras that is only concerned withneqo-transportand that would reduce the noise. Downside, additional complexity, as the problem itself is only half fixed, i.e. inneqo-transportbut notneqo-http3.