feat(lib/utils.js): support firefox esr#153
Conversation
Rob--W
left a comment
There was a problem hiding this comment.
Thanks for your PR!
Could you split the PR in two separate parts, one that refactors and another that introduces new features? That would make it easier to see what actually changes in support of the feature.
And although it probably does not matter in this small library, in general splitting the commit also makes it easier to do regression testing if needed, with git bisect.
Please include a unit test in https://github.com/mozilla/node-fx-runner/blob/master/test/run/test.utils.js
|
cc @Rob--W tests are passing now 😄 |
|
I'm trying to verify whether the paths for ESR are correct. Could you state the Firefox versions and operating systems where you verified the accuracy of the paths included in this PR? P.S. I had forgotten about this PR until I went through my unread notifications. If you don't get a reply within a week or two, feel free to ping me as a reminder. |
Fixes #112
This PR adds support for detecting Firefox ESR binaries across macOS, Windows, and Linux, and cleans up
utils.jsfor improved readability and maintainability.User Impact
-b esroresras the binary option, and the runner will resolve the appropriate Firefox ESR binary for their operating system.#### Code Modernization- Replaced legacy function expressions with arrow functions where appropriate.- Prefixed Node.js built-in modules withnode:per current Node.js convention.- Removed redundant"use strict"directives, as they are unnecessary in current Node.js environments.- Refactored template strings in place of string concatenation for improved clarity.