Extract Lang attribute for marked contents by edoardocavazza · Pull Request #20407 · mozilla/pdf.js

edoardocavazza · 2025-10-29T18:52:58Z

Some marked contents have a Lang attribute defined in the props passed to the beginMarkedContentProps operator. With this PR, the evaluator extracts this information. I chose to pass the props object as third argument in order to maintain backwards compatibility, but I'm open to changes.

calixteman · 2025-10-30T18:31:44Z

+      const pdfDoc = await loadingTask.promise;
+      const pdfPage = await pdfDoc.getPage(1);
+
+      pdfDoc.annotationStorage.setValue("30R", { value: "test" });


There is no annotations in the pdf so I don't see the point of setting these values.

Uh I am sorry, bad copy/paste from a previous test. Removed

calixteman · 2025-11-17T19:01:37Z

Could you rebase your patch ?

calixteman · 2025-11-21T17:22:52Z

/botio test

moz-tools-bot · 2025-11-21T17:22:54Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d64eb63a5678ba9/output.txt

moz-tools-bot · 2025-11-21T17:22:54Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d18703028e4f9f/output.txt

moz-tools-bot · 2025-11-21T18:22:56Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0d18703028e4f9f/output.txt

Total script time: 60.00 mins

moz-tools-bot · 2025-11-21T18:38:06Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d64eb63a5678ba9/output.txt

Total script time: 75.18 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/d64eb63a5678ba9/reftest-analyzer.html#web=eq.log

calixteman · 2025-11-21T18:47:03Z

@edoardocavazza Can you check the failure in issue12909 ?

nicolo-ribaudo · 2025-12-09T12:11:23Z

The lang property can affect which font the browser falls back to, and thus its size. In src/display/text_layer.js there a bunch of calls to #getCtx with the correct language to be able to measure how wide the text rendered by the browser will be, and scale it accordingly.

If some of the elements in the text layer are going to have a different language, we need to make sure to get the measurements with the appropriate canvas context (this might be what's causing the horizontal scaling difference in issue12909).

codecov-commenter · 2026-07-05T13:27:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.43%. Comparing base (330cc4f) to head (52e7a3c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20407      +/-   ##
==========================================
+ Coverage   89.41%   89.43%   +0.01%     
==========================================
  Files         262      262              
  Lines       66738    66761      +23     
==========================================
+ Hits        59675    59705      +30     
+ Misses       7063     7056       -7

Flag	Coverage Δ
browsertest	`66.53% <100.00%> (+0.03%)`	⬆️
fonttest	`9.05% <ø> (ø)`
integrationtest	`68.75% <100.00%> (+0.02%)`	⬆️
unittest	`57.38% <96.66%> (+0.04%)`	⬆️
unittestcli	`56.31% <40.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Snuffleupagus · 2026-07-05T15:29:21Z

+      const opList = await pdfPage.getOperatorList();
+      expect(opList.fnArray[0]).toEqual(OPS.beginMarkedContentProps);


Nit: Improve readability by adding a blank line before the expect statements.

Suggested change

const opList = await pdfPage.getOperatorList();

expect(opList.fnArray[0]).toEqual(OPS.beginMarkedContentProps);

const opList = await pdfPage.getOperatorList();

expect(opList.fnArray[0]).toEqual(OPS.beginMarkedContentProps);

Snuffleupagus · 2026-07-05T15:30:23Z

+      expect(opList.argsArray[10][2]?.lang).toEqual("es-ES");
+    });


This test doesn't clean-up after itself.

Suggested change

expect(opList.argsArray[10][2]?.lang).toEqual("es-ES");

});

expect(opList.argsArray[10][2]?.lang).toEqual("es-ES");

await loadingTask.destroy();

});

Snuffleupagus · 2026-07-05T15:30:50Z

+    expect(span.textContent).toEqual("Esto es español");
+  });


This test doesn't clean-up after itself.

Suggested change

expect(span.textContent).toEqual("Esto es español");

});

expect(span.textContent).toEqual("Esto es español");

await loadingTask.destroy();

});

Snuffleupagus · 2026-07-05T15:33:01Z

+    let langAscentCache = this.#ascentCache.get((lang ||= ""));
+    if (langAscentCache) {
+      const cachedAscent = langAscentCache.get(fontFamily);
+      if (cachedAscent) {
+        return cachedAscent;
+      }
+    } else {
+      langAscentCache = new Map();
+      this.#ascentCache.set(lang, langAscentCache);


This can probably be shortened?

Suggested change

let langAscentCache = this.#ascentCache.get((lang ||= ""));

if (langAscentCache) {

const cachedAscent = langAscentCache.get(fontFamily);

if (cachedAscent) {

return cachedAscent;

}

} else {

langAscentCache = new Map();

this.#ascentCache.set(lang, langAscentCache);

const langAscentCache = this.#ascentCache.getOrInsertComputed(

(lang ||= ""),

makeMap

);

const cachedAscent = langAscentCache.get(fontFamily);

if (cachedAscent) {

return cachedAscent;

}

Snuffleupagus · 2026-07-05T21:14:02Z

+            let props = null;
+            if (args[1] instanceof Dict) {
+              const lang = args[1].get("Lang");
+              if (typeof lang === "string") {
+                props = Object.create(null);
+                props.lang = stringToPDFString(lang);
+              }
+            }
+


Wait, why are we adding unused data here (outside of a single unit-test)!?

This means adding effectively dead code in the Firefox PDF Viewer, and it'll also be overall (ever so slightly) less efficient since this data first of all needs to be parsed and secondly it needs to be sent to the main-thread.

calixteman reviewed Oct 30, 2025

View reviewed changes

Comment thread test/unit/api_spec.js

calixteman reviewed Oct 30, 2025

View reviewed changes

Comment thread src/core/evaluator.js

timvandermeij added the core label Nov 1, 2025

edoardocavazza added 3 commits July 5, 2026 15:15

Extract Lang attribute for marked contents

0390ff5

Push marked_content_lang.pdf

69b5054

Fix test with NodeJS check

5893aa5

calixteman force-pushed the marked-content-lang branch from 9f576be to cc9f9cf Compare July 5, 2026 13:26

calixteman temporarily deployed to code-coverage July 5, 2026 13:26 — with GitHub Actions Inactive

Snuffleupagus reviewed Jul 5, 2026

View reviewed changes

Comment thread test/unit/api_spec.js Outdated

Comment thread src/core/evaluator.js Outdated

Remove useless access to annotation storage in test

52e7a3c

calixteman force-pushed the marked-content-lang branch from cc9f9cf to 52e7a3c Compare July 5, 2026 15:19

calixteman temporarily deployed to code-coverage July 5, 2026 15:19 — with GitHub Actions Inactive

Snuffleupagus reviewed Jul 5, 2026

View reviewed changes

		const opList = await pdfPage.getOperatorList();
		expect(opList.fnArray[0]).toEqual(OPS.beginMarkedContentProps);

Uh oh!

Conversation

edoardocavazza commented Oct 29, 2025

Uh oh!

calixteman Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

edoardocavazza Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

calixteman commented Nov 17, 2025

Uh oh!

calixteman commented Nov 21, 2025

Uh oh!

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Nov 21, 2025

Uh oh!

nicolo-ribaudo commented Dec 9, 2025

Uh oh!

codecov-commenter commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Snuffleupagus Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

Snuffleupagus Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

Snuffleupagus Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

Snuffleupagus Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

Snuffleupagus Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov-commenter commented Jul 5, 2026 •

edited

Loading

Snuffleupagus Jul 5, 2026 •

edited

Loading