Skip to content

fix:add conditions in textInputChecker. x#21124

Open
ddgotyou wants to merge 1 commit into
mozilla:masterfrom
ddgotyou:fix/password-input-prevent-fix
Open

fix:add conditions in textInputChecker. x#21124
ddgotyou wants to merge 1 commit into
mozilla:masterfrom
ddgotyou:fix/password-input-prevent-fix

Conversation

@ddgotyou

Copy link
Copy Markdown

som PASSWORD TYPE INPUTS will be prevented from DEFAULT ACTIONS(like deleting).

@ddgotyou

ddgotyou commented Apr 20, 2026

Copy link
Copy Markdown
Author

Dear all,
When I open a pdf page using PDF.JS,My password inputs cannot delete.
It is bothering, but I find the solution that the checker just needed to complete conditions.
I think this will help us to employ our pdf.JS more comfortably.
Looking forward to your acception.

@codecov-commenter

codecov-commenter commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (330cc4f) to head (fb3c21d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21124      +/-   ##
==========================================
+ Coverage   89.41%   89.42%   +0.01%     
==========================================
  Files         262      262              
  Lines       66738    66737       -1     
==========================================
+ Hits        59675    59681       +6     
+ Misses       7063     7056       -7     
Flag Coverage Δ
browsertest 66.53% <33.33%> (+0.03%) ⬆️
fonttest 9.05% <ø> (ø)
integrationtest 68.72% <100.00%> (-0.01%) ⬇️
unittest 57.35% <33.33%> (+0.01%) ⬆️
unittestcli 56.30% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/display/editor/tools.js Outdated
…om PASSWORD TYPE INPUTS will be prevented from DEFAULT ACTIONS(like deleting).

Co-authored-by: Calixte Denizet <calixte.denizet@gmail.com>
@calixteman calixteman force-pushed the fix/password-input-prevent-fix branch from 732b02b to fb3c21d Compare July 5, 2026 14:35
@calixteman calixteman requested a review from timvandermeij July 5, 2026 17:56

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this up!

}
}

// The `type` values of the `<input>` elements which don't hold editable text.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good now, but please amend the commit message so that the intent of the change is clear from the Git logs too before landing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants