Skip to content

Enable the unicorn/logical-assignment-operators ESLint plugin rule#21511

Merged
timvandermeij merged 2 commits into
mozilla:masterfrom
Snuffleupagus:eslint-logical-assignment-operators
Jul 4, 2026
Merged

Enable the unicorn/logical-assignment-operators ESLint plugin rule#21511
timvandermeij merged 2 commits into
mozilla:masterfrom
Snuffleupagus:eslint-logical-assignment-operators

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Note: Submitting as draft, since the second commit may not be desirable since it perhaps affects readability too much in some cases?

@codecov-commenter

codecov-commenter commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.39%. Comparing base (5b100c4) to head (046e68d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21511      +/-   ##
==========================================
- Coverage   89.40%   89.39%   -0.01%     
==========================================
  Files         262      262              
  Lines       66762    66746      -16     
==========================================
- Hits        59690    59670      -20     
- Misses       7072     7076       +4     
Flag Coverage Δ
browsertest 66.52% <87.50%> (-0.01%) ⬇️
fonttest 9.05% <0.00%> (+<0.01%) ⬆️
integrationtest 68.72% <83.33%> (+0.01%) ⬆️
unittest 57.31% <68.75%> (-0.03%) ⬇️
unittestcli 56.30% <68.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7ef8c01be1a85aa/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dd11dbb6f8c955e/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/dd11dbb6f8c955e/output.txt

Total script time: 18.12 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/7ef8c01be1a85aa/output.txt

Total script time: 25.27 mins

  • Regression tests: Passed

@Snuffleupagus Snuffleupagus marked this pull request as ready for review July 2, 2026 13:27
@Snuffleupagus Snuffleupagus force-pushed the eslint-logical-assignment-operators branch from 74ce8af to 046e68d Compare July 4, 2026 10:27
@timvandermeij timvandermeij merged commit c79b005 into mozilla:master Jul 4, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good to me; thanks!

@Snuffleupagus Snuffleupagus deleted the eslint-logical-assignment-operators branch July 4, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants