Skip to content

Remove unneeded this.#signatureData = null; lines in src/core/document.js#21536

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:PDFDocument-rm-unneeded-signatureData-null
Jul 4, 2026
Merged

Remove unneeded this.#signatureData = null; lines in src/core/document.js#21536
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:PDFDocument-rm-unneeded-signatureData-null

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Given that this is the initial value of the field, setting it again when no signatures exist is pointless.

…ment.js`

Given that this is the *initial value* of the field, setting it again when no signatures exist is pointless.
@codecov-commenter

codecov-commenter commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.40%. Comparing base (5b100c4) to head (20e0d6d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21536      +/-   ##
==========================================
- Coverage   89.40%   89.40%   -0.01%     
==========================================
  Files         262      262              
  Lines       66762    66760       -2     
==========================================
- Hits        59690    59688       -2     
  Misses       7072     7072              
Flag Coverage Δ
browsertest 66.53% <ø> (+<0.01%) ⬆️
fonttest 9.05% <ø> (ø)
integrationtest 68.72% <ø> (+<0.01%) ⬆️
unittest 57.32% <ø> (-0.02%) ⬇️
unittestcli 56.30% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks!

@timvandermeij timvandermeij merged commit cb70c93 into mozilla:master Jul 4, 2026
21 checks passed
@Snuffleupagus Snuffleupagus deleted the PDFDocument-rm-unneeded-signatureData-null branch July 4, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants