Skip to content

Lookup "lenIV" inline in the Type1Parser.prototype.extractFontProgram method#21544

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:extractFontProgram-lenIV
Jul 5, 2026
Merged

Lookup "lenIV" inline in the Type1Parser.prototype.extractFontProgram method#21544
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:extractFontProgram-lenIV

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Using an intermediate variable seems completely unnecessary here.

Also, while unrelated, move a HINTING_ENABLED check to avoid pointless Array-length checks.

…m` method

Using an intermediate variable seems completely unnecessary here.

Also, while unrelated, move a `HINTING_ENABLED` check to avoid pointless Array-length checks.
@codecov-commenter

codecov-commenter commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.41%. Comparing base (e148b15) to head (a4ed5b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21544   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files         262      262           
  Lines       66739    66737    -2     
=======================================
- Hits        59677    59676    -1     
+ Misses       7062     7061    -1     
Flag Coverage Δ
browsertest 66.52% <100.00%> (-0.01%) ⬇️
fonttest 9.05% <0.00%> (+<0.01%) ⬆️
integrationtest 68.73% <100.00%> (-0.01%) ⬇️
unittest 57.33% <100.00%> (-0.01%) ⬇️
unittestcli 56.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fe3919173a9dd0b/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4cd20a7e344cb04/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/fe3919173a9dd0b/output.txt

Total script time: 18.07 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/4cd20a7e344cb04/output.txt

Total script time: 25.70 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit f03e18f into mozilla:master Jul 5, 2026
21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thanks!

@Snuffleupagus Snuffleupagus deleted the extractFontProgram-lenIV branch July 5, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants