Skip to content

Implement a unit test for passing unsupported data types to MurmurHash3_64.update()#21546

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
timvandermeij:murmurhash-test
Jul 5, 2026
Merged

Implement a unit test for passing unsupported data types to MurmurHash3_64.update()#21546
Snuffleupagus merged 1 commit into
mozilla:masterfrom
timvandermeij:murmurhash-test

Conversation

@timvandermeij

Copy link
Copy Markdown
Collaborator

This commit brings the coverage of src/shared/murmurhash3.js to 100%.

…sh3_64.update()`

This commit brings the coverage of `src/shared/murmurhash3.js` to 100%.
@codecov-commenter

codecov-commenter commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (bf924ff) to head (f0818c1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21546   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files         262      262           
  Lines       66702    66702           
=======================================
+ Hits        59648    59651    +3     
+ Misses       7054     7051    -3     
Flag Coverage Δ
unittest 57.32% <ø> (+<0.01%) ⬆️
unittestcli 56.27% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Snuffleupagus

This comment was marked as outdated.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@Snuffleupagus Snuffleupagus merged commit 98ccc87 into mozilla:master Jul 5, 2026
12 checks passed
@Snuffleupagus Snuffleupagus removed the request for review from calixteman July 5, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants