feat(server): bump MAX_CONCURRENT_TASKS default 3 → 5 (TAB-966)#452
Closed
srbiv wants to merge 1 commit into
Closed
feat(server): bump MAX_CONCURRENT_TASKS default 3 → 5 (TAB-966)#452srbiv wants to merge 1 commit into
srbiv wants to merge 1 commit into
Conversation
The previous default of 3 was sized against the memory math in TAB-964, which assumed in-pod Chromium browsers (~300-400MB each). In practice the pod connects to a remote browser pool over CDP and per-task memory in the pod is much smaller. 5 is comfortable on the 2Gi pod limit that the companion webservices-infra change lands. Companion infra change pins MAX_CONCURRENT_TASKS=5 in the configmap so deploys are explicit about the cap rather than relying on this default. Refs: TAB-966, TAB-964
srbiv
force-pushed
the
stafford/tab-966-pilo-scale-on-cap-utilization
branch
from
72a7b1e to
3c735a0
Compare
srbiv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the in-code default
MAX_CONCURRENT_TASKSfrom 3 to 5.The previous default of 3 was sized against the memory math in TAB-964, which framed per-task memory as
~300-400MBassuming in-pod Chromium browsers. In practice the pod connects to a remote browser pool over CDP — per-task memory in the pilo pod is much smaller (JS heap, CDP buffers, ARIA snapshots, LLM context). 5 is comfortable on the 2Gi pod limit that the companion infra change lands.Companion change
webservices-infrabranchsbrooke/tab-966-pilo-scale-on-cap-utilization:averageValue: 1600MiHPA threshold withaverageUtilization: 40so HPA actually fires before the cap is hitbehavior.scaleUpfor fast burst responseMAX_CONCURRENT_TASKS=5in the configmap so deploys are explicit rather than relying on this code defaultDeploy ordering
Land the infra change first so cap=5 has memory headroom before the pilo image rolls out.
Test plan
pnpm run checkpasses — 8 server test files, 96 tests; cli/extension/core all greenRefs: TAB-966, TAB-964