feat: show individual build servers capacity in --dist-status#2714
Open
iTrooz wants to merge 2 commits into
Open
feat: show individual build servers capacity in --dist-status#2714iTrooz wants to merge 2 commits into
iTrooz wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
==========================================
- Coverage 74.41% 70.83% -3.58%
==========================================
Files 70 70
Lines 39211 39137 -74
==========================================
- Hits 29177 27723 -1454
- Misses 10034 11414 +1380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a field
serversto the status returned by the scheduler, and subsequently to the JSON returned bysccache --dist-status. The primary benefit of this (for me) is to have ain_progressstatus per-server, which can be useful for the user to have a view of his compilation cluster.I plan to submit a PR to add Prometheus metrics to the scheduler/build servers later, which would include this information among other, so I'd understand if you closed this PR (although I still see avalue in being able to quickly tell which servers are being scheduled atm)
New JSON:
{ "SchedulerStatus": [ "https://sccache.example.com", { "num_servers": 5, "num_cpus": 60, "in_progress": 0, "servers": [ { "address": "1.1.1.1:8080", "num_cpus": 12, "in_progress": 0 }, { "address": "2.1.1.1:8080", "num_cpus": 12, "in_progress": 0 }, { "address": "3.1.1.1:8080", "num_cpus": 12, "in_progress": 0 }, { "address": "4.1.1.1:8080", "num_cpus": 12, "in_progress": 0 }, { "address": "5.1.1.1:8080", "num_cpus": 12, "in_progress": 0 } ] } ] }