Bump opendal to 0.56.0 and fix fallout (fixes local GCS cache usage)#2715
Open
flip1995 wants to merge 2 commits into
Open
Bump opendal to 0.56.0 and fix fallout (fixes local GCS cache usage)#2715flip1995 wants to merge 2 commits into
flip1995 wants to merge 2 commits into
Conversation
- Required bump of reqwest to 0.13.0
- Rename and remove features deprecated in that release
- Update `Cargo.lock` file
- Remove direct `reqsign` dependency that was not used in the code
- Add new opendal-layer-logging dependency that was split out of opendal
- Fix fallout in code from `LoggingLayer` split in opendal
flip1995
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
==========================================
- Coverage 74.41% 73.57% -0.84%
==========================================
Files 70 70
Lines 39211 39559 +348
==========================================
- Hits 29177 29104 -73
- Misses 10034 10455 +421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Not sure why CI is failing. I'd appreciate any pointers how I can try to reproduce those locally and debug. EDIT: Managed to reproduce the dist tests locally. |
Author
|
Hm, the dist tests are running into this issue: seanmonstar/reqwest#2988 |
Author
|
@sylvestre could you approve the CI run please. I think my latest commit has fixed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reqsigndependency that was not used in the codeCargo.lockfileLoggingLayersplit in opendalMotivation:
authorized_usercredential apache/opendal#6287The gcs cache can currently not be used with
authorized_userapplication-default credentials, as this was not supported inreqsignversion 0.16.5, whichopendalversion0.55.0depended on. This was fixed in a later version of reqsign and since has been updated inopendalWith this, the gcs cache should Just Work ™️ after a
gcloud auth application-default login.Should fix #2670