Skip to content

Bug 2052225 - Fix - Edit Revisions Internal Server Error #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmiculit wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −2
Open

Bug 2052225 - Fix - Edit Revisions Internal Server Error #9660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions treeherder/webapp/api/performance_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,15 @@ def to_representation(self, obj):
return []


class RepositoryScopedRevisionField(serializers.SlugRelatedField):
def get_queryset(self):
queryset = super().get_queryset()
repository_id = getattr(self.root.instance, "repository_id", None)
if repository_id is not None:
queryset = queryset.filter(repository_id=repository_id)
return queryset


class BackfillRecordSerializer(serializers.Serializer):
context = serializers.JSONField()
status = serializers.IntegerField()
Expand Down Expand Up @@ -307,7 +316,7 @@ class PerformanceAlertSummarySerializer(serializers.ModelSerializer):
)
repository = serializers.SlugRelatedField(read_only=True, slug_field="name")
framework = serializers.SlugRelatedField(read_only=True, slug_field="id")
revision = serializers.SlugRelatedField(
revision = RepositoryScopedRevisionField(
read_only=False,
slug_field="revision",
source="push",
Expand All @@ -318,7 +327,7 @@ class PerformanceAlertSummarySerializer(serializers.ModelSerializer):
read_only=True, slug_field="revision", source="original_push"
)
push_timestamp = TimestampField(source="push", read_only=True)
prev_push_revision = serializers.SlugRelatedField(
prev_push_revision = RepositoryScopedRevisionField(
read_only=False,
slug_field="revision",
source="prev_push",
Expand Down