Refactored UUID into SessionID interface#132
Open
dlorych wants to merge 3 commits intomrniko:masterfrom
Open
Conversation
rest of code to use it. Modified AuthorizeHandler to check for sessionID in handshake data - AuthorizationListener is able to extract data from Cookie and put it back to HandshakeData.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Introducing AuthorizationHandler was a great step forward, finally we can integrate our websites with netty-socketio. Unfortunately, the session ids used by apps does not have to comply with UUID format.
To overcome this I have created a SessionID interface and an abstract factory SessionIDFactory, with default implementation based on UUID. The developers can now create their own implementations of session ids using their formats.
The project is missing unit tests, and I did not have time yet to verify the solution is not breaking any other functionality.
Feel free to merge these changes if you find it useful.