Open
Conversation
Author
|
Add close methode for client |
Contributor
liangyuanpeng
left a comment
liangyuanpeng
left a comment
There was a problem hiding this comment.
Thanks for your work and add some comment.
| <groupId>com.corundumstudio.socketio</groupId> | ||
| <artifactId>netty-socketio</artifactId> | ||
| <version>1.7.20-SNAPSHOT</version> | ||
| <version>1.7.20</version> |
Contributor
There was a problem hiding this comment.
I think this change is don't need to update.
| if(entry.getValue().getListeners().contains(listener)){ | ||
| entry.getValue().getListeners().remove(listener); | ||
| } | ||
| if(entry.getValue().getListeners().size() == 0){ |
Contributor
There was a problem hiding this comment.
IMO,Use isEmpty would be great.
| void disconnect(); | ||
|
|
||
| /** | ||
| * Disconnect client |
Contributor
There was a problem hiding this comment.
What's different with disconnect() ? it's possible to add this change to disconnect ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of a remove method for listeners