Bug 🐛 Instagram API returns error messages as 200 OK responses#6
Open
andersrehn wants to merge 1 commit into
Open
Bug 🐛 Instagram API returns error messages as 200 OK responses#6andersrehn wants to merge 1 commit into
andersrehn wants to merge 1 commit into
Conversation
…ata payload to prevent PHP fatal crashes if the response is not complete.
Owner
|
Thanks for the PR! The bigger issue is access to the Facebook Graph API is now automatically deactivated when an unpublished app is inactive for a while. I wasn't able to find the exact details of this and if this inactivity is due to someone not logging into the app dashboard or API calls (I doubt the later but its possible on low traffic websites). In the meantime, I'll merge this PR if you could make the requested change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the scenarios where the OAuth response is to be considered an error. I have noticed that the Instagram OAuth could respond with a valid 200 but it contains an error inside.
If the response data payload is not properly checked to ensure there is a payload, other parts of the application will assume all went well.
Here is an example payload I got from the Instagram API when my token had expired.
When Instagram sends this payload the following piece of code tries to read undefined properties.
instagram-api/api.php:21inside functioninstagram_get_user_items.Tested on PHP 8.0