arm64: dts: qcom: sdm450: Add Samsung Galaxy Tab A 10.5 (2018, LTE)#254
Open
m8l8th814n-eng wants to merge 6 commits into
Open
arm64: dts: qcom: sdm450: Add Samsung Galaxy Tab A 10.5 (2018, LTE)#254m8l8th814n-eng wants to merge 6 commits into
m8l8th814n-eng wants to merge 6 commits into
Conversation
Add a device tree for the Samsung Galaxy Tab A 10.5 (2018) LTE variant (SM-T595, gta2xllte), based on SDM450 with a PM8953 PMIC. Supported: eMMC/SD (SDHCI), USB, volume/power keys, regulators, and Wi-Fi/Bluetooth (WCNSS pronto + WCN3680 iris). Display (HX8279 DSI), touchscreen (ST fts1ba90a) and the modem are not wired up yet. Signed-off-by: Simon <m8l8th814n@gmail.com>
m8l8th814n-eng
added a commit
to m8l8th814n-eng/gta2xllte-mainline
that referenced
this pull request
Jun 26, 2026
The device is the LTE variant (SM-T595, gta2xllte, SDM450 msm-id 338), not gta2xlwifi. Rename the dts to sdm450-samsung-gta2xllte (include sdm450.dtsi, compatible samsung,gta2xllte / qcom,sdm450), update scripts, README and the upstream dts. Kernel PR: msm8953-mainline/linux#254. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
@m8l8th814n-eng You should make your change against the latest release branch master is not in use. |
Author
|
Okay will look into that tnx |
vldly
reviewed
Jul 16, 2026
| linux,code = <KEY_VOLUMEUP>; | ||
| }; | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
No reserved-memory? On downstream it's defined in same file as a6plte so it should need the same regions.
barni2000
requested changes
Jul 16, 2026
Comment on lines
+27
to
+28
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&gpio_key_default>; |
Member
There was a problem hiding this comment.
Please follow upstream dt rules pinctrl-names comes after pinctrl-0, https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=next-20260715
| }; | ||
|
|
||
| &wcnss { | ||
| status = "okay"; |
Member
There was a problem hiding this comment.
status should be the last property.
|
|
||
| cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; | ||
|
|
||
| pinctrl-names = "default", "sleep"; |
| compatible = "samsung,gta2xllte", "qcom,sdm450"; | ||
| chassis-type = "tablet"; | ||
|
|
||
| qcom,msm-id = <338 0>; |
Removed comment about black panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a device tree for the Samsung Galaxy Tab A 10.5 (2018) LTE variant (SM-T595, gta2xllte), SDM450 + PM8953.
Working / enabled:
Display (HX8279 DSI panel), touchscreen (ST fts1ba90a) and the modem are not wired up yet. lk2nd already has a matching gta2xllte entry (T595*).
Tested by RAM-booting via lk2nd: boots to userspace, Wi-Fi associates (wcn36xx loads with the device NV blob).