Skip to content

cygcheck: remove an unused variable causing a build error with GCC 16 + zstd CI fix#340

Merged
lazka merged 2 commits into
msys2:msys2-3.6.9from
lazka:gcc16-build-fix
May 18, 2026
Merged

cygcheck: remove an unused variable causing a build error with GCC 16 + zstd CI fix#340
lazka merged 2 commits into
msys2:msys2-3.6.9from
lazka:gcc16-build-fix

Conversation

@lazka
Copy link
Copy Markdown
Member

@lazka lazka commented May 18, 2026

Since gcc 16 this triggers -Werror=unused-but-set-variable= Remove the unused variable.

../../../.././winsup/utils/mingw/cygcheck.cc: In function 'void dump_sysinfo()':
../../../.././winsup/utils/mingw/cygcheck.cc:1709:11: error: variable 'count_path_items' set but not used [-Werror=unused-but-set-variable=]
 1709 |       int count_path_items = 0;
      |           ^~~~~~~~~~~~~~~~

lazka added 2 commits May 18, 2026 21:13
Since gcc 16 this triggers -Werror=unused-but-set-variable=
Remove the unused variable.
See 1387ea9 - our binutils now pulls in zstd, and
cygwin will only consider linking to it if it is present.
Install it so it is found at configure time.
@lazka lazka merged commit f2d12f5 into msys2:msys2-3.6.9 May 18, 2026
9 checks passed
@lazka lazka changed the title cygcheck: remove an unused variable causing a build error with GCC 16 cygcheck: remove an unused variable causing a build error with GCC 16 + zstd CI fix May 18, 2026
@lazka
Copy link
Copy Markdown
Member Author

lazka commented May 18, 2026

The new zstd dependency for the dumper is due to msys2/MSYS2-packages#6240 I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant