Render help shortcuts with the reader's own modifier labels - #522
Merged
Conversation
The articles write shortcuts with the PC labels; the docs page now swaps Ctrl+ for Cmd+ and Alt+ for Option+ for Apple readers, through appleShortcutLabels in the keys helper. The per-line '(Cmd on a Mac)' parentheticals go, and the shortcuts article's convention line says what the reader actually sees. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #520: the /docs articles still showed Ctrl and Alt on a Mac, leaning on a convention line. The docs page now rewrites combo labels (
Ctrl+toCmd+,Alt+toOption+) for Apple readers via a newappleShortcutLabelsin$lib/keys(unit-tested; only the combo forms are touched, so prose naming the keys stays as written). The per-line "(Cmd on a Mac)" parentheticals across editor, planning, getting-started, and reviewing are gone, and the shortcuts article's intro now says shortcuts are shown for your keyboard.SSR serves the written PC form; the swap lands on mount, same caveat as every modLabel user.
Verified locally: lint, check, keys unit tests, docs.spec.
🤖 Generated with Claude Code