Index Service IDs#40
Merged
Merged
Conversation
This was referenced Nov 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for indexing service IDs in the GTFS provider implementation, enabling optional integer-based service ID storage alongside string-based IDs. The changes align with updates made in the commons-java repository.
Key changes:
- Renamed variables and methods from
serviceIdtoserviceIdOrIntto reflect dual support for string and integer service IDs - Added conditional logic using
FeatureFlags.F_EXPORT_SERVICE_ID_INTSto handle both ID formats - Introduced new database table for service IDs with corresponding initialization logic
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| GTFSStatusProviderTest.kt | Renamed test methods and function calls to use filterServiceIdOrInts |
| gtfs_rts_values.xml | Added new string resource for service ID cleanup regex configuration |
| GTFSStatusProvider.java | Updated service ID filtering and lookup logic to support both string and integer formats |
| GTFSRealTimeProvider.java | Added service ID cleanup regex pattern support (currently unused) |
| GTFSProviderDbHelper.java | Added service IDs table creation and initialization logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.