Export trips.trip_id#11
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new feature flags and database definitions to support exporting trip_id. The changes are mostly correct, but I've identified a couple of areas for improvement. Specifically, the new T_TRIP_IDS table is missing a primary key definition, which is crucial for data integrity and foreign key relationships. I've also suggested a minor formatting improvement to adhere to common file conventions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces support for exporting trips.trip_id by adding a new trip IDs table and related feature flags. The changes enable mapping between integer trip IDs and string trip IDs, similar to the existing service IDs functionality.
Key Changes:
- Added new
trip_idstable with SQL creation, insertion, and drop statements - Introduced feature flags for trip ID integers and trip ID arrival exports
- Renamed
unescapeStringOrNulltounquotesUnescapeStringOrNullfor clarity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/mtransit/commons/GTFSCommons.kt | Added trip_ids table schema and updated comments for service_ids and strings tables |
| src/main/java/org/mtransit/commons/FeatureFlags.kt | Added feature flags for trip ID exports with WIP annotations |
| src/main/java/org/mtransit/commons/sql/SQLUtils.kt | Renamed function from unescapeStringOrNull to unquotesUnescapeStringOrNull |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces new feature flags and database definitions to support exporting trips.trip_id. The changes are generally good, including resolving a TODO for T_SERVICE_IDS_SQL_CREATE and a small refactoring in SQLUtils.kt. I've left a couple of suggestions for improvement: one to remove a redundant boolean operation for clarity, and another to address code duplication of constants to improve maintainability.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.