Remove export original route & service exception types feature flags#6
Merged
mmathieum merged 1 commit intoNov 4, 2025
Conversation
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes two obsolete feature flags, F_EXPORT_ORIGINAL_ROUTE_TYPE and F_EXPORT_SERVICE_EXCEPTION_TYPE. The changes are straightforward, removing the flags from FeatureFlags.kt and the corresponding conditional logic from GTFSCommons.kt. Since the flags were already enabled, this is a safe cleanup that improves code maintainability by removing dead code. The changes are well-executed and I have no further recommendations.
mmathieum
deleted the
mm/remove_ff_gtfs_export_orig_route_service_except_types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.