feat: make record-screenshots workflow compatible with main app (org.mtransit.android)#766
Draft
Copilot wants to merge 2 commits into
Draft
feat: make record-screenshots workflow compatible with main app (org.mtransit.android)#766Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
- Add `modules` workflow input (JSON array of {pkg, repo} objects)
- Remove main-repo exclusion from job condition
- Skip "download main app APK" for main repo (main app IS this repo)
- "Download/build this app APK" steps output MAIN_APK_FILE for main repo
- Add validation step to fail early when main repo runs without modules
- Add "download module APKs" step that writes a pkg:apk_file manifest
- Timezone step falls back to UTC for main repo without error
- Pass MODULE_APK_FILES_MANIFEST to emulator step
- setup-and-all-app-screenshots.sh: accept manifest for multi-module install
Copilot created this pull request from a session on behalf of
mmathieum
May 29, 2026 19:57
View session
Updated default value for modules to include a JSON array of module details.
mmathieum
reviewed
May 29, 2026
mmathieum
left a comment
mmathieum
left a comment
Member
There was a problem hiding this comment.
- should create different workflow? Need to be compat w/ multiple time zones...
mmathieum
reviewed
Jun 1, 2026
Comment on lines
+17
to
+24
| modules: | ||
| description: 'JSON array of modules to install: [{"pkg":"...","repo":"..."}] (required for main repo)' | ||
| required: false | ||
| default: | | ||
| [ | ||
| {"pkg":"org.mtransit.android.ca_montreal_amt_train", "repo":"https://github.com/mtransitapps/ca-montreal-amt-train-android" } | ||
| ] | ||
| type: string |
Member
There was a problem hiding this comment.
@copilot this should not be a workflow input but a static environment variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mt-record-screenshotsworkflow was hardcoded for single-module agency repos and explicitly excluded the main app. This adds amodulesinput to support defining multiple agency modules to download and install, enabling screenshot generation from the main app repo.Workflow (
mt-record-screenshots.yml)modulesinput — JSON array of{pkg, repo}pairs; each entry's latest release APK is downloaded and installed before screenshots runifconditionMAIN_APK_FILEwhenMT_IS_MAIN_REPO=true,MODULE_APK_FILEotherwisemodulesinput is empty when running from the main repomodulesJSON withjq, downloads each APK viadownload_latest_apk.sh, and writes apkg:apk_filemanifestexit 1(no single-agency timezone XML)MODULE_APK_FILES_MANIFESTenv var to the setup scriptSetup script (
setup-and-all-app-screenshots.sh)MODULE_APK_FILE(single module, agency repos) orMODULE_APK_FILES_MANIFEST(multi-module, main repo); errors if neither is setexit 1on installation failure in both paths