chore: bump localrecall to fix PostgreSQL collection name with ':' (#10375)#10387
Merged
Conversation
… fix Pulls mudler/LocalRecall#48, which makes sanitizeTableName allowlist valid identifier characters so collection names containing ':' (e.g. the per-user "legacy-api-key:<agent>" namespace) no longer break PostgreSQL CREATE TABLE with "syntax error at or near ':'". Fixes #10375 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
added a commit
that referenced
this pull request
Jun 24, 2026
…10471) fix(agents): URL-decode collection/agent name path params Collection and agent names carry a "legacy-api-key:" prefix, so the ':' arrives percent-encoded as %3A in the request path. Echo routes such paths via URL.RawPath and stores the matched path-param value still escaped, so c.Param("name") returned "legacy-api-key%3ALiteraryResearch" and the store lookup 404'd ("collection not found"). This was second-order fallout of #10375/#10387: once colons became valid in names, the URL-decode gap surfaced on every name-bearing endpoint. Add a decodedParam helper that url.PathUnescape's the param (falling back to the raw value on invalid encoding) and wire it into all collection endpoints and the agent :name endpoints, which share the identical prefix. The entry endpoints already unescaped c.Param("*"); this closes the same gap for :name. Fixes #10443 Assisted-by: Claude:claude-opus-4-8 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Co-authored-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
github.com/mudler/localrecallto pull in mudler/LocalRecall#48.Why
Fixes #10375. LocalAI namespaces per-user collections as
{userID}:{name}. Under legacy API-key auth theuserIDis the literallegacy-api-key, so an agent's collection name becomeslegacy-api-key:<agent>. localrecall'ssanitizeTableNameonly replaced-,.and:leaked into the interpolatedCREATE TABLEDDL:This prevented agents with knowledge base / long-term memory from creating their PostgreSQL collection.
The upstream fix switches
sanitizeTableNameto an allowlist ([A-Za-z0-9_]→ keep, everything else →_), producing a valid unquoted identifier for any collection name while preserving the per-useruserIDprefix that isolates tenants on a shared database.Notes
go.mod/go.sum(localrecall…9a3b3321a9cd→…d0073dd5dc32).core/services/agentpool/...builds clean against the new version.