refactor(agents): bump skillserver, drop redundant Name from list_skills output#9916
Merged
Conversation
mudler
force-pushed
the
worktree-fix-9868-agent-skills
branch
from
9f67d19 to
694088e
Compare
localai-bot
changed the title
…lls/search_skills skillserver's list_skills MCP tool used to ship every entry with name="" (field was commented out), while search_skills populated it - two tools with inconsistent shape for the same data. skill.Name and skill.ID are populated from the same source string anyway (the directory name), so returning both was pure duplication. Bumps github.com/mudler/skillserver to a7317cb, which drops the Name field from both SkillInfo and SearchResult and leaves ID as the single canonical identifier (already what read_skill consumes). Adds core/services/skills/skills_mcp_test.go, a regression that drives the LocalAI FilesystemManager through an in-process MCP session and asserts a newly-created skill is visible by ID on the still-open session. This is a cleanup, not the root cause of #9868 - the reporter likely sees something deeper than a cosmetic JSON shape issue. Assisted-by: Claude:claude-opus-4-7 [Claude Code] Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
force-pushed
the
worktree-fix-9868-agent-skills
branch
from
694088e to
230665d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup, not a fix for #9868.
skillserver's
list_skillsMCP tool was emitting every entry withname: ""(the field was commented out inpkg/mcp/tools.go), whilesearch_skillswas populating it — two tools with inconsistent shape over the same data.skill.Nameandskill.IDare both set from the same source string (FileSystemManager.readSkillFromPath:Name: skillName; ID: skillName), so returning both was pure duplication.This PR:
github.com/mudler/skillserverto commita7317cb, which dropsNamefrom bothSkillInfoandSearchResult.IDstays as the single canonical identifier (already whatread_skilltakes as input).core/services/skills/skills_mcp_test.go, a Ginkgo regression that drives the LocalAIFilesystemManagerthrough an in-process MCP session and asserts a newly-created skill is visible by ID on the still-open session — guards the manager↔session lifecycle.Note on #9868
This started as an attempt at #9868, but the empty-
namecosmetic isn't a plausible cause of "skills_list is always empty []" — the LLM would still getidpopulated. #9868 stays open; this PR is just the dependency cleanup that surfaced along the way.Test plan
go test ./core/services/skills/ -run TestSkillsMCP— passes.