chore(docker): pin pg_textsearch to v1.3.1#50
Merged
Conversation
The image built pg_textsearch from the moving main branch, shipping an unreproducible "1.0.0-dev". That dev build's bm25 access method could wedge an INSERT on a buffer-content lock indefinitely (uninterruptible — only a Postgres restart cleared it), holding the relation lock and stalling every other operation on the collection. Pin to the latest tagged release (v1.3.1, same 1.x major as what was deployed, so the bm25 SQL stays compatible) via a shallow tag clone, and expose PG_TEXTSEARCH_VERSION as a build arg for deliberate future bumps. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:claude-opus-4-8 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PostgreSQL image built
pg_textsearchfrom the movingmainbranch, producing an unreproducible1.0.0-dev. That dev build'sbm25access method could wedge anINSERTon a buffer-contentLWLockindefinitely — uninterruptible (pg_terminate_backendhad no effect; only a Postgres restart cleared it) — holding the relation lock and stalling every other operation on the collection (observed in production: a 4-day-wedged INSERT with 75CREATE INDEXqueued behind it). This is the root tooling risk behind #49.Pin to the latest tagged release
v1.3.1(same1.xmajor as what was deployed, so LocalRecall'sto_bm25query/text_configSQL stays compatible) via a shallow tag clone, and exposePG_TEXTSEARCH_VERSIONas a build arg for deliberate future bumps.Verified
--branch v1.3.1resolves to the tag and the tree still has theMakefile(make && make installunchanged). No image build run here (long Rust/pgvectorscale compile); the clone step is the only change.Assisted-by: Claude:claude-opus-4-8 [Claude Code]