[docs] Demo chrome tweaks#4983
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,229.50 ms -67.86 ms(-5.2%) | Renders: 50 (+0) | Paint: 1,845.67 ms -82.03 ms(-4.3%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
15d768a to
d0963f7
Compare
I'd match the non-collapsed line count (on |
Maybe I'm over-indexing on consistency with non-collapsible blocks. 4 vs 7 lines is 96px vs 156px from what I see (with Button), which doesn't doesn't feel too much extra? But if you said 12 lines is the limit, then some non-collapsible blocks would be inconsistent anyway, I guess... It's just that, 4 just looks weirdly short to the point where it seems somewhat pointless to even show a partially expanded state, while 7 is somewhat justified given it shows the top of the component function.
Yeah I meant non-collapsed as in non-collapsible here, code blocks short enough that they don't collapse at all |
colmtuite
left a comment
There was a problem hiding this comment.
- Tab label needs to be aligned with code block like it is on prod.
- All toolbar text should be aligned like it is on prod
- We need an extra LOC visible, or something, so there is never a blank code line visible which looks weird
3de0642 to
540ed48
Compare
157c29d to
e052246
Compare
Updated |


Preview:
Changes: