fix(containers): render EmbedGoogleMap locally to avoid boolean className#443
Merged
Merged
Conversation
…Name muy@1.1.0's Iframe sets `className: variant === "cover" && classes.cover`, which yields `false` when variant is not cover and triggers a MUI Box PropTypes warning. Implements the iframe locally with string-safe className resolution and full unit test coverage (embed URL, cover variant, className forwarding, no boolean className warning). Closes #440 Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
muy'sEmbedGoogleMapwith a local MUIBox/iframeimplementation insrc/containers/EmbedGoogleMap, soclassNameis always a string or omitted. Upstreammuy@1.1.0setsclassName: variant === "cover" && classes.cover, which yieldsfalsewithoutvariant="cover"and triggers the MUI Box PropTypes warning.classNameforwarding, and the absence of the boolean-classNamewarning; the container is at 100% statement/branch coverage.Closes #440
Test plan
npm test— related suites (EmbedGoogleMap, LocationStep, ParkingExpansionPanel) greenMade with Cursor