fix(seo): default description and title from site metadata#456
Merged
Conversation
metax SEO marks description as required; IndexTemplate and other pages often omit it. The local SEO wrapper now falls back to useSiteMetadata(), IndexTemplate passes an explicit home description, and TROUBLESHOOTING documents the warning. Upstream metax fix: muy/muy#154 / muy/muy#155. Closes #455 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEOwrapper defaultsdescriptionandtitlefromuseSiteMetadata()when omitted (silences metax PropTypes).IndexTemplatepasses an explicit home-page description.TROUBLESHOOTING.md.Closes #455
Test plan
npm test -- --testPathPattern=SEOMade with Cursor