Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
diff --git a/include/internal/catch_session.cpp b/include/internal/catch_session.cpp
index 21877c99..19ba7ceb 100644
--- a/include/internal/catch_session.cpp
+++ b/include/internal/catch_session.cpp
@@ -182,6 +182,17 @@ namespace Catch {
if( m_configData.libIdentify )
libIdentify();
m_config.reset();
+
+ auto const& factories = Catch::getRegistryHub().getReporterRegistry().getFactories();
+ if( factories.find( m_configData.reporterName ) == factories.end() ) {
+ Catch::cerr()
+ << Colour( Colour::Red )
+ << "\nError(s) in input:\n"
+ << Column( "Unrecognized reporter: '" + m_configData.reporterName + "'" ).indent( 2 )
+ << "\n\n";
+ return MaxExitCode;
+ }
+
return 0;
}

diff --git a/single_include/catch2/catch.hpp b/single_include/catch2/catch.hpp
index 4191607a..26f5b144 100644
--- a/single_include/catch2/catch.hpp
+++ b/single_include/catch2/catch.hpp
@@ -10145,6 +10145,17 @@ namespace Catch {
if( m_configData.libIdentify )
libIdentify();
m_config.reset();
+
+ auto const& factories = Catch::getRegistryHub().getReporterRegistry().getFactories();
+ if( factories.find( m_configData.reporterName ) == factories.end() ) {
+ Catch::cerr()
+ << Colour( Colour::Red )
+ << "\nError(s) in input:\n"
+ << Column( "Unrecognized reporter: '" + m_configData.reporterName + "'" ).indent( 2 )
+ << "\n\n";
+ return MaxExitCode;
+ }
+
return 0;
}

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"org": "catchorg", "repo": "Catch2", "number": 1422, "valid": false, "error_msg": "After applying the fix patch, no test cases transitioned from failed to passed. A brief summary is as follows: Test Result Summary:\nStage Descriptions:\n run : Execute the test command without any patches applied.\n test : Execute the test command after applying the test patch.\n fix : Execute the test command after applying both the test patch and the fix patch.\nEach stage is reported as (pass, fail, skip), representing the number of tests that passed, failed, or were skipped, respectively.\n\nResults:\n run = (8, 0, 0)\n test = (6, 2, 0)\n fix = (6, 2, 0)", "fixed_tests": {}, "p2p_tests": {}, "f2p_tests": {}, "s2p_tests": {}, "n2p_tests": {}, "run_result": {"passed_count": 8, "failed_count": 0, "skipped_count": 0, "passed_tests": ["approvaltests", "listtags", "notest", "listreporters", "runtests", "listtestnamesonly", "listtests", "noassertions"], "failed_tests": [], "skipped_tests": []}, "test_patch_result": {"passed_count": 6, "failed_count": 2, "skipped_count": 0, "passed_tests": ["listtags", "notest", "noassertions", "listreporters", "listtestnamesonly", "listtests"], "failed_tests": ["approvaltests", "runtests"], "skipped_tests": []}, "fix_patch_result": {"passed_count": 6, "failed_count": 2, "skipped_count": 0, "passed_tests": ["listtags", "notest", "listreporters", "listtestnamesonly", "listtests", "noassertions"], "failed_tests": ["approvaltests", "runtests"], "skipped_tests": []}}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/include/internal/catch_message.cpp b/include/internal/catch_message.cpp
index df905bf6..e8aa6458 100644
--- a/include/internal/catch_message.cpp
+++ b/include/internal/catch_message.cpp
@@ -63,7 +63,7 @@ namespace Catch {
auto start = std::string::npos;
for( size_t pos = 0; pos <= names.size(); ++pos ) {
char c = names[pos];
- if( pos == names.size() || c == ' ' || c == '\t' || c == ',' || c == ']' ) {
+ if( pos == names.size() || c == ',' || c == ']' ) {
if( start != std::string::npos ) {
m_messages.push_back( MessageInfo( macroName, lineInfo, resultType ) );
m_messages.back().message = names.substr( start, pos-start) + " := ";
diff --git a/single_include/catch2/catch.hpp b/single_include/catch2/catch.hpp
index b324e56a..30ad09fc 100644
--- a/single_include/catch2/catch.hpp
+++ b/single_include/catch2/catch.hpp
@@ -8845,7 +8845,7 @@ namespace Catch {
auto start = std::string::npos;
for( size_t pos = 0; pos <= names.size(); ++pos ) {
char c = names[pos];
- if( pos == names.size() || c == ' ' || c == '\t' || c == ',' || c == ']' ) {
+ if( pos == names.size() || c == ',' || c == ']' ) {
if( start != std::string::npos ) {
m_messages.push_back( MessageInfo( macroName, lineInfo, resultType ) );
m_messages.back().message = names.substr( start, pos-start) + " := ";
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"org": "catchorg", "repo": "Catch2", "number": 1448, "valid": false, "error_msg": "After applying the fix patch, no test cases transitioned from failed to passed. A brief summary is as follows: Test Result Summary:\nStage Descriptions:\n run : Execute the test command without any patches applied.\n test : Execute the test command after applying the test patch.\n fix : Execute the test command after applying both the test patch and the fix patch.\nEach stage is reported as (pass, fail, skip), representing the number of tests that passed, failed, or were skipped, respectively.\n\nResults:\n run = (8, 0, 0)\n test = (5, 1, 0)\n fix = (5, 1, 0)", "fixed_tests": {}, "p2p_tests": {}, "f2p_tests": {}, "s2p_tests": {}, "n2p_tests": {}, "run_result": {"passed_count": 8, "failed_count": 0, "skipped_count": 0, "passed_tests": ["approvaltests", "listtags", "notest", "listreporters", "runtests", "listtestnamesonly", "listtests", "noassertions"], "failed_tests": [], "skipped_tests": []}, "test_patch_result": {"passed_count": 5, "failed_count": 1, "skipped_count": 0, "passed_tests": ["listtags", "notest", "listreporters", "listtestnamesonly", "listtests"], "failed_tests": ["approvaltests"], "skipped_tests": []}, "fix_patch_result": {"passed_count": 5, "failed_count": 1, "skipped_count": 0, "passed_tests": ["listtags", "notest", "listreporters", "listtestnamesonly", "listtests"], "failed_tests": ["approvaltests"], "skipped_tests": []}}
Loading
Loading