🔧 Maintenance round#1042
Merged
Merged
Conversation
denialhaag
added
documentation
Member
Author
|
@coderabbitai full review |
Contributor
✅ Action performedFull review finished. |
denialhaag
commented
Jun 17, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR reworks the ChangesCI and Workflow Changes
Docs, Branding, and Repo Config
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 269-271: The allowed-skips condition for standard C++ tests uses
AND logic between the skip conditions, but the job's skip condition itself uses
OR logic. Change the AND operator (&&) to OR operator (||) in the allowed-skips
condition at line 269 so that the cpp-tests jobs are added to allowed-skips when
either !run-cpp-tests is true OR the extensive-cpp-ci label is present. This
will ensure the alls-green check properly handles all skip scenarios for the
cpp-tests-ubuntu, cpp-tests-macos, and cpp-tests-windows jobs.
- Around line 289-291: The allowed-skips condition for python-tests-extensive
uses AND operators when it should use OR operators. The job skips when
run-python-tests is false OR event_name is not a pull_request OR the
extensive-python-ci label is missing. Update the condition in the allowed-skips
section to use OR logic instead of AND logic so that the python-tests-extensive
job is correctly marked as allowed to skip when any of these skip conditions are
met (not when all of them are met simultaneously). This will prevent alls-green
from failing when the job legitimately skips due to being a push to main rather
than a pull request.
- Around line 273-275: The allowed-skips condition on lines 273-275 uses AND
logic (&&) to combine three skip conditions, but this is incorrect—it should use
OR logic (||) to match the actual skip condition from line 86. Currently, when
there is a push event with C++ changes where run-cpp-tests evaluates to true,
the !fromJSON(needs.change-detection.outputs.run-cpp-tests) condition becomes
false, causing the entire AND expression to evaluate to false and preventing the
extensive tests from being recognized as allowed-skips, which then causes the
alls-green check to fail. Change the && operators connecting
!fromJSON(needs.change-detection.outputs.run-cpp-tests),
!contains(github.event.pull_request.labels.*.name, 'extensive-cpp-ci'), and
github.event_name != 'pull_request' to || operators so that if ANY ONE of these
skip conditions is true, the extensive jobs are properly allowed to be skipped.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0f263fde-3d78-4295-afbd-d2ddf335f06c
📒 Files selected for processing (8)
.github/workflows/ci.yml.github/workflows/templating.yml.gitignore.readthedocs.yamlREADME.mddocs/conf.pydocs/index.mdpyproject.toml
💤 Files with no reviewable changes (1)
- pyproject.toml
Member
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
burgholzer
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes several maintenance updates:
required-checks-passjobclient-idinstead ofapp-idCLAUDE.mdcbuildwheelinstallsdelvewheelby defaultChecklist
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.I have added migration instructions to the upgrade guide (if needed).