fix(ios): dispatch thermal EventChannel callbacks on main queue#14
Merged
kevmo314 merged 1 commit intoJun 3, 2026
Merged
Conversation
ProcessInfo.thermalStateDidChangeNotification can fire on a background queue. Calling FlutterEventSink off the main thread triggers NSInternalInconsistencyException in the Flutter engine. Also remove the notification observer in onCancel.
Contributor
|
Thanks! |
|
Hey @kevmo314! 👋 When will this change be available on pub.dev? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessInfo.thermalStateDidChangeNotificationcan be delivered on a background dispatch queue. The current implementation invokesFlutterEventSinkdirectly fromonThermalStateChanged, which must run on the main thread. This causesNSInternalInconsistencyExceptionin the Flutter engine when the device thermal state changes (e.g. under memory pressure while backgrounding).This change:
DispatchQueue.main.async[weak self]NotificationCenterobserver inonCancelwhen the stream is cancelledReproduction
Observed in production application on Model: iPhone 13 Mini iOS Version:26.5.0 using thermal 1.2.1 when memory pressure + app background coincided with a thermal state notification.
Stack (abbreviated):
Test plan
onThermalStatusChangedon a physical iOS device