Skip to content

Use Empty rather than Any for message processing#62

Merged
mwitkow merged 1 commit into
mwitkow:masterfrom
adamthesax:fix/truncated-repeated-fields
Feb 12, 2023
Merged

Use Empty rather than Any for message processing#62
mwitkow merged 1 commit into
mwitkow:masterfrom
adamthesax:fix/truncated-repeated-fields

Conversation

@adamthesax
Copy link
Copy Markdown
Contributor

This fixes #61. This is also based off of #57

@vito
Copy link
Copy Markdown

vito commented Nov 4, 2022

@mwitkow Sorry to nag, but any chance this could be merged? 🙂 I ran into this issue as well.

edit: cc @bwplotka as I see you've merged something most recently 🙏

@floatingstatic
Copy link
Copy Markdown

Hi, I would also like to see if we can bump looking into merging this. For me this fixes both #59 and #61

Thanks!

@tzasacky
Copy link
Copy Markdown

Bump, I ran into this issue as well.

@dlakshma
Copy link
Copy Markdown

dlakshma commented Dec 26, 2022

This fixes #61. This is also based off of #57
#59
Wanted to check the reason why this PR request is not merged. With the suggested fix "grpc: failed to unmarshal the received message string field contains invalid UTF-8" is not seen when querying the gRPC server using the grpc-proxy

@ghost
Copy link
Copy Markdown

ghost commented Jan 13, 2023

Thanks for the fix which saves my life! Though this hasn't been merged yet.

@andremarianiello
Copy link
Copy Markdown

I need this change too! Thanks!

@mwitkow
Copy link
Copy Markdown
Owner

mwitkow commented Feb 12, 2023

Hi folks, sorry for not looking into this earlier. I rarely read my github messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fields marked as repeated are truncated

7 participants