Open
Conversation
This was referenced May 13, 2021
jkirschner
force-pushed
the
fix-stringAt-and-indexAt
branch
from
d1dcef1 to
2499acd
Compare
Author
|
@myliang : thank you for your patience. I know it took me some time to resubmit these latest pull requests based on your feedback to make them smaller. Please let me know if there's anything I can do to support your review of this (and my other recent pull requests), or any feedback to address. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where stringAt fails for strings greater than 2 characters.
Improves documentation of indexAt and stringAt.