fix(hookd): recover clusters after dispatch stream failure#337
Merged
Conversation
A failed `stream.Send` means the registered `deployd` stream can no longer be trusted. Leaving that stream in `onlineClustersMap` can keep later deploys routed to dead state and block a clean `deployd` reconnect. The observed `RST_STREAM` failure does not prove `HAProxy` caused the reset, but it exposed a stale-registration path that `hookd` should treat as terminal.
Contributor
Author
|
Forsøk på kort/konsis write-up av hvorfor dette burde kunne fikse problemet: https://gist.github.com/x10an14-nav/0d91596335eb38dd2df3fe8ba85a4b38 |
Contributor
|
Jeg merger denne for å se om dette løser problemet vårt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed
stream.Sendmeans the registereddeploydstream can no longer be trusted.Leaving that stream in
onlineClustersMapcan keep later deploys routed to dead state and block a cleandeploydreconnect.The observed
RST_STREAMfailure does not proveHAProxycaused the reset, but it exposed a stale-registration path thathookdshould treat as terminal.