refactor: move modules into modules/ subdirectory#13
Merged
Conversation
Aligns this repo with the convention already used by sister labs (nan-ai-engineering-labs, nan-data-engineering-labs): all numbered module directories now live under modules/ instead of at the repo root. Changes: - git mv 16 module dirs (01_python_fundamentals .. 16_modern_security) into modules/, preserving full git history via rename tracking - scripts: introduce modules/ awareness in validate_all_modules.py, audit_nan_modules.py, validate_nan_language.py, link_check.py, progress.py, generate_structure.py, run_topic_tests.py — CLI args remain bare (--module 11_modern_tooling_2026), prepended internally - run_topic_tests.py accepts both bare and modules/-prefixed paths - README.md: 32 link updates to point at modules/<NN>/... - Pre-existing X1 failures in modules 12 (fastapi) and 15 (data science) are unchanged by this refactor (verified against main)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns this repo with the layout already used by sister labs (
nan-ai-engineering-labs,nan-data-engineering-labs): all 16 numbered module directories now live undermodules/instead of at the repo root. Companion PR: nanlabs/nan-ai-native-engineering-labs#36.Changes
git mv16 modules (01_python_fundamentals→16_modern_security) intomodules/. Renames recorded at 100% similarity — full history preserved (git log --followworks).modules/awareness in:scripts/validate_all_modules.py(iter_modulesreadsrepo_root / "modules")scripts/audit_nan_modules.py(same)scripts/validate_nan_language.py(module_path = repo_root / "modules" / args.module)scripts/link_check.py(MODULES_ROOTconstant)scripts/progress.py(scan_modules(base_path / "modules"))scripts/generate_structure.py(base_path = ... / "modules")scripts/run_topic_tests.py— accepts both bare andmodules/-prefixed paths via fallback--module 11_modern_tooling_2026,python scripts/run_topic_tests.py 11_modern_tooling_2026/...); scripts prependmodules/internally.README.md— 32 link updates to point atmodules/<NN>/.....github/workflows/*.ymlalready use globs that match under the new layout.pyproject.tomlunchanged —testpaths = ["tests"]is unaffected.AGENTS.md,GETTING_STARTED.md,STATUS.md,CONTRIBUTING.md— no module path references found, no changes needed.Verification (local — all green; pre-existing failures unchanged)
python3 scripts/validate_all_modules.pymainbaseline (modules 12 fastapi + 15 data-science have pre-existing X1 failures unrelated to this refactor)python3 scripts/audit_nan_modules.pymodules/python3 scripts/validate_nan_language.py --module 11_modern_tooling_2026python3 scripts/run_topic_tests.py 11_modern_tooling_2026/35_debugpy_remote_debugging(bare)modules/fallbackpython3 scripts/run_topic_tests.py modules/11_modern_tooling_2026/...(explicit)python3 scripts/link_check.py --topic <sample>ast.parse(generate_structure.py)git log --follow modules/<NN>/<topic>/README.mdTest plan
git mvrename detection at 100% similarityrun_topic_tests.pyworks for both bare andmodules/-prefixed CLI args