Skip to content

fix: resolve named CommonJS imports in dev-server bundling ("No matching export") #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theoryeffects wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix: resolve named CommonJS imports in dev-server bundling ("No matching export") #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/tools/esbuild/node-modules-bundler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,16 @@ function createAngularLinkerPlugin(

const needsLinking = requiresLinking(args.path, contents);

if (!needsLinking && !advancedOptimizations) {
// Genuine ESM vendor files may skip the transform in dev (advancedOptimizations=false)
// to keep the dev server fast. CommonJS files may not: esbuild resolves their named
// exports via the CJS->ESM interop that `jsTransformer.transformData` performs, so
// skipping it makes `import { named } from '<cjs-pkg>'` fail with "No matching export"
// during `ng serve` (while `ng build`, where advancedOptimizations=true, transforms every
// file and works). Only skip the transform for non-CommonJS files, so CJS interop no
// longer depends on the optimization level.
const maybeCommonjs = /\bmodule\.exports\b|\bexports\.[A-Za-z_$]/.test(contents);

if (!needsLinking && !advancedOptimizations && !maybeCommonjs) {
return null;
}

Expand Down