fix(email): skip SMTP AUTH when no username (local relay)#21
Merged
Conversation
…elay) The test email failed with "No compatible authentication mechanism was found": send_text always attached SMTP credentials, so against a local postfix on localhost:25 that accepts mail WITHOUT auth (and advertises no AUTH mechanism) lettre refused to send. Only attach credentials when smtp_user is non-empty; an empty username now means "no AUTH", which is the right behavior for an unauthenticated localhost relay. Authenticated provider relays (user set) are unchanged. clippy -D warnings clean; adapters suite green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
localhost:25:25fix. The test email now reacheslocalhost:25but fails withNo compatible authentication mechanism was found—send_textalways attaches SMTP credentials, so against a local postfix that accepts mail without auth (no AUTH mechanism advertised), lettre refuses to send.Fix: only attach credentials when Username is set. Empty username ⇒ no AUTH (correct for an unauthenticated localhost relay); a configured provider relay (Postmark/Mailgun/…) authenticates as before.
After this +
update.sh, your test to matej@nechodom.cz with empty user/pass againstlocalhost:25should send (postfix then handles outbound).clippy
-D warningsclean; adapters suite green.🤖 Generated with Claude Code