Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| function EditSignup(): React.JSX.Element { | ||
| const data = useSingleSignupLoader(); | ||
| const { eventId } = useParams(); | ||
| const teamMembersUrl = `/events/${eventId}/team_members`; |
Contributor
There was a problem hiding this comment.
disallow literal string: teamMembersUrl = /events/${eventId}/team_members
Handle null from SingleValue<T> (isClearable selects) and readonly from MultiValue<T> across all affected components. For non-nullable GraphQL fields (defaultLayout, rootPage), guard against null with short-circuit evaluation since the API would reject null values anyway. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
TypeScript now types catch clause variables as unknown. Fix by using instanceof guards, as-casts where the throw source guarantees Error objects (Apollo mutations), and widening parseResponseErrors to accept unknown instead of Error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r errors ColumnDef<TData, TValue> has invariant TValue in TypeScript 6, so mixed arrays must be typed as ColumnDef<T, any>[]. Also fix Timespan comparators to accept nullable DateTime values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add ambient module declaration for vite/modulepreload-polyfill (TS2882) - Fix ColumnReservationSet properties initialized via clear() method (TS2564) - Fix ScheduledValueTimespanRow valueChanged callback to accept undefined (TS2345) - Fix setupI18Next formatter lng param to accept undefined (TS2345) - Fix useAsyncFetcher resolve cast to match ref type (TS2322) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use `as` casts with `typeof formItem` switch narrowing to handle stricter Dispatch<SetStateAction<T>> variance in TypeScript 6. Update formItemPropertyUpdater to accept Dispatch<SetStateAction<T>>. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add function overloads to PermissionsTableInput to fix JSX component usage - Cast `add` function from useChangeSet to UsePermissionsChangeSetOptions type in CmsContentGroupFormFields, EditCmsContentGroup, NewCmsContentGroup, EditStaffPositionPermissions, and useOrganizationRoleForm Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Cast ObjectDiffDisplay before/after props in FormItemChangeDisplay - Fix isValueOther type predicate in MultipleChoiceItemDisplay - Fix run and onChange types in EditRunModal - Widen newResponseValues parameter types in useEventForm, EventProposalForm, UserConProfileForm, and MyProfileForm Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix buildScheduledMoneyValueInput to materialize functional updates instead of forwarding SetStateAction (fixes PricingStructureForm) - Fix EditPricingStructureModal local type to use NonNullable to avoid null in useState type, removing redundant cast - Use PricingStructureFormProps/PricingStructureModalState as cast targets in EditProductForm and PricingStructureInput - Fix AdminProductVariantsTable onChange type to accept SetStateAction - Fix AdminOrderEntriesTable ProductSelect onChange cast - Fix CouponForm MoneyInput onChange to handle functional updates - Cast setProduct and setTicketType in EditTicketProvidingProductModal and EditTicketType Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix AuthenticityTokensContext key indexing - Fix FileUploadForm ProgressEvent type parameter - Cast memo'd generic callbacks in ScheduledValuePreview - Cast DataModeApplicationEntry as ComponentType<unknown> in application.tsx - Fix UserActivityAlerts notification destination cast types - Cast setLanguage in ConventionFormGeneralSection and NewConventionModal - Cast onChange in EventListFilterableFormItemDropdown - Fix StaffPositionsTable reduce type to use generic parameter - Spread Set to array in ReactTableExportButtonWithColumnTransform - Cast setFormState in EditUser Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Change GraphQLAsyncSelect/UserConProfileSelectProps constraint to TypedDocumentNode<any, any> to handle TypeScript 6 variance checking of phantom type parameters (needed to bypass the contravariant TVariables check that bare TypedDocumentNode introduces) - Cast DevModeGraphiql fetcher to resolve Observable type mismatch - Fix parsePageContent reduce accumulator type to include CSSProperties, cast processNode callbacks and AUTHENTICATION_LINK_PROCESSING_INSTRUCTIONS to avoid contravariant ProcessingInstruction<T> errors Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove required teamMembersUrl prop from EditSignup and derive the URL
internally from useParams, allowing the component to be used as a
route Component (which requires ComponentType<{}>)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nbudin
force-pushed
the
upgrade-typescript-6
branch
from
2aed159 to
248ce09
Compare
nbudin
commented
Apr 8, 2026
|
|
||
| useEffect(() => { | ||
| if (navigation.state === 'idle' && actionData != null && !error) { | ||
| // eslint-disable-next-line react-hooks/set-state-in-effect |
Contributor
Author
There was a problem hiding this comment.
Return to this, see if we can eliminate it
nbudin
commented
Apr 8, 2026
| }, [client]); | ||
|
|
||
| useEffect(() => { | ||
| // eslint-disable-next-line react-hooks/set-state-in-effect |
Contributor
Author
There was a problem hiding this comment.
revisit this to see if we can remove it
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key changes
SingleValue/MultiValuecomponent generic type constraintsColumnDefvariance andDateTimenullable comparator errorsPermissionsTableInput; castuseChangeSetaddfunctions throughoutform_response_attrscallback parameter types to handle contravarianceDispatch<SetStateAction>variance; materialize functional updates inbuildScheduledMoneyValueInputTypedDocumentNodeconstraint toTypedDocumentNode<any, any>to handle TypeScript 6's proper variance checking of phantom type parametersparsePageContent: FixProcessingInstruction<T>contravariance; fix reduce accumulator typesComponentType<{}>)ProgressEventtype parameters, memo'd generic callback casts,reducegenerics,flatMapwithSetTest plan
yarn run tsc --noEmit)🤖 Generated with Claude Code