Skip to content

return int from Transpile method for better error handling #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbenazechJlsa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

return int from Transpile method for better error handling #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/TypedSignalR.Client.TypeScript.Generator/App.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public App(ILogger<App> logger)
_logger = logger;
}

public async Task Transpile(
public async Task<int> Transpile(
[Option('p', Description = "Path to the project file (Xxx.csproj)")]
string project,
[Option('o', Description ="Output directory")]
Expand Down Expand Up @@ -56,11 +56,15 @@ public async Task Transpile(

_logger.Log(LogLevel.Information, "======== Transpilation is completed. ========");
_logger.Log(LogLevel.Information, "Please check the output folder: {output}", output);

return 0;
}
catch (Exception ex)
{
_logger.Log(LogLevel.Information, "======== Exception ========");
_logger.Log(LogLevel.Error, "{ex}", ex);

return 1;
}
}

Expand Down