Auto-reconcile duplicate relationship types in LLM-generated schemas#536
Merged
NathalieCharbel merged 4 commits intoJun 1, 2026
Merged
Conversation
serengil-neo4j
approved these changes
Jun 1, 2026
bc005b6 to
25b011f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to guarantee a
GraphSchemaauto-generated from text by an LLM (SchemaFromTextExtractor) never ends up with two or morerelationship_typesentries that share the samelabel.Rather than hard failing an auto-generated schema, this PR reconciles duplicate relationship types:
validate_extraction_dict_to_graph_schemanow merges same-labelrelationship_typesinto a single entry whose properties are the union of the duplicates' properties (de-duplicated by name, first-occurrence wins on conflicts), keeps the first entry's non-property fields, and logs a warning for each merged label. The merge runs on the raw extraction dict before the cross-reference filters andmodel_validate, so the unioned property set is visible to both - a previously dropped/misreported constraint now validates correctly.PS:
Type of Change
Complexity
Complexity: low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):