Example of aborting fetch with an AbortController and CancellationToken#104
Open
kjvalencik wants to merge 1 commit into
Open
Example of aborting fetch with an AbortController and CancellationToken#104kjvalencik wants to merge 1 commit into
kjvalencik wants to merge 1 commit into
Conversation
2 tasks
vadimpiven
reviewed
Jun 8, 2026
|
|
||
| const timeout = Number(process.argv[2]) || 10000; | ||
|
|
||
| async function main() { |
There was a problem hiding this comment.
Maybe this should be
async function callAbortable<T>(
callback: (token: CancellationToken) => Promise<T>,
signal: AbortSignal,
): Promise<T> {
const token = new CancellationToken();
const abort = () => token.cancel();
try {
signal.addEventListener('abort', abort, { once: true });
signal.throwIfAborted();
return await callback(token);
} finally {
signal.removeEventListener('abort', abort);
}
}
async function main() {
const version = process.version;
const date = await callAbortable(
(token) => nodeReleaseDateWithAbort(version, token),
AbortSignal.timeout(timeout),
);
console.log(date);
}to avoid calling addon if the signal is already aborted and clean-up listener to avoid memory leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of adapting a JavaScript
AbortControllerto a tokioCancellationToken.TODO: Include docs on how this works.
Usage