Update tooling and add rector to CI

Author: cracksalad

.github/workflows/ci.yml

@@ -44,15 +44,20 @@ jobs:
       matrix:
         php:
           - version: "8.0"
-            phpunit: "9" 
+            phpunit: "9"
+            args: "" 
           - version: "8.1"
             phpunit: "10"
+            args: ""
           - version: "8.2"
             phpunit: "10"
+            args: ""
           - version: "8.3"
-            phpunit: "10"
+            phpunit: "11"
+            args: ""
           - version: "8.4"
-            phpunit: "10"
+            phpunit: "12"
+            args: --display-deprecations --display-phpunit-deprecations
 
     name: "Test: PHP ${{ matrix.php.version }}"
 
@@ -74,4 +79,21 @@ jobs:
           version: "${{ matrix.php.phpunit }}"
           php_version: "${{ matrix.php.version }}"
           php_extensions: xdebug
-          args: --coverage-text
+          args: "--coverage-text ${{ matrix.php.args }}"
+
+  rector:
+    runs-on: ubuntu-latest
+    name: Rector
+    
+    steps:
+      - uses: actions/checkout@v5
+      - name: Cache Composer dependencies
+        uses: actions/cache@v4
+        with:
+          path: /tmp/composer-cache
+          key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
+      - uses: php-actions/composer@v6
+        with:
+          php_version: "8.4"
+      - name: Check compatibility
+        run: composer rector

.phive/phars.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="phpunit" version="^10.0 || ^11.0" installed="11.5.42" location="./tools/phpunit" copy="true"/>
+  <phar name="phpunit" version="^10.0 || ^11.0 || ^12.0" installed="12.4.2" location="./tools/phpunit" copy="true"/>
   <phar name="psalm" version="^6.4.0" installed="6.13.1" location="./tools/psalm" copy="true"/>
   <phar name="phpcpd" version="^6.0.0" installed="6.0.3" location="./tools/phpcpd" copy="true"/>
 </phive>

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "nerou/large-array-buffer",
-    "version": "1.2.0",
+    "description": "Handle arrays with huge cardinality but small items with ease",
     "type": "library",
     "license": "MIT",
     "authors": [
@@ -22,6 +22,7 @@
         "php": ">=8.0"
     },
     "require-dev": {
+        "rector/rector": "^2.0",
         "squizlabs/php_codesniffer": "^4.0"
     },
     "prefer-stable": true,
@@ -45,11 +46,13 @@
         "psalm": "./tools/psalm --no-diff --use-baseline=psalm.baseline.xml --php-version=8.0",
         "psalm-stats": "./tools/psalm --no-diff --use-baseline=psalm.baseline.xml --php-version=8.0 --stats | grep -v 100",
         "update-psalm-baseline": "./tools/psalm --no-diff --set-baseline=psalm.baseline.xml",
+        "rector": "./vendor/bin/rector process --dry-run",
         "tests": [
             "@phpcs",
             "@phpunit",
             "@phpcpd",
-            "@psalm"
+            "@psalm",
+            "@rector"
         ]
     },
     "scripts-descriptions": {
@@ -60,6 +63,7 @@
         "psalm": "Runs static analysis.",
         "psalm-stats": "Print files with unsafe types based on psalm.",
         "update-psalm-baseline": "Updates baseline for psalm. CAUTION should not be run as a regular procedure!",
+        "rector": "Runs PHP compatibility checks and code smell analysis.",
         "tests": "Runs all available tests."
     }
 }

rector.php

@@ -0,0 +1,24 @@
+<?php
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\ValueObject\PhpVersion;
+use Rector\Set\ValueObject\LevelSetList;
+use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
+
+return static function (RectorConfig $rectorConfig): void {
+  $rectorConfig->paths([
+    __DIR__.'/src',
+    __DIR__.'/test'
+  ]);
+  
+  $rectorConfig->phpVersion(PhpVersion::PHP_85);
+
+  $rectorConfig->sets([
+    LevelSetList::UP_TO_PHP_80
+  ]);
+  
+  $rectorConfig->skip([
+    ClassPropertyAssignToConstructorPromotionRector::class
+  ]);
+};

test/ArrayBufferTest.php

@@ -4,6 +4,7 @@
 namespace LargeArrayBuffer\Tests;
 
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use LargeArrayBuffer\ArrayBuffer;
 
 /**
@@ -22,7 +23,7 @@ public static function provideTestData(): array {
   /**
    * @dataProvider provideTestData
    */
-  //#[DataProvider('provideTestData')]
+  #[DataProvider('provideTestData')]
   public function testBuffer(int $items, int $threshold): void {
     $o = new \stdClass();
     $o->foo = 'hello world!'.PHP_EOL;

test/LargeArrayBufferTest.php

@@ -5,6 +5,7 @@
 
 use LargeArrayBuffer\LargeArrayBuffer;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 /**
  * @author Andreas Wahlen
@@ -58,7 +59,7 @@ public static function provideConfig(): \Generator {
   /**
    * @dataProvider provideConfig
    */
-  //#[DataProvider('provideConfig')]
+  #[DataProvider('provideConfig')]
   public function testReadWrite(int $serializer, int $compression): void {
     $o = self::getObject();
     $buf = new LargeArrayBuffer(serializer: $serializer, compression: $compression);
@@ -71,7 +72,7 @@ public function testReadWrite(int $serializer, int $compression): void {
   /**
    * @dataProvider provideConfig
    */
-  //#[DataProvider('provideConfig')]
+  #[DataProvider('provideConfig')]
   public function testLoop(int $serializer, int $compression): void {
     $count = 1500;
     $buf = new LargeArrayBuffer(serializer: $serializer, compression: $compression);
@@ -116,6 +117,7 @@ public static function provideItems(): array {
   /**
    * @dataProvider provideItems
    */
+  #[DataProvider('provideItems')]
   public function testToArray(array $items): void {
     $buf = new LargeArrayBuffer();
     foreach($items as $item){
@@ -127,6 +129,7 @@ public function testToArray(array $items): void {
   /**
    * @dataProvider provideItems
    */
+  #[DataProvider('provideItems')]
   public function testToFixedArray(array $items): void {
     $buf = new LargeArrayBuffer();
     foreach($items as $item){
@@ -138,6 +141,7 @@ public function testToFixedArray(array $items): void {
   /**
    * @dataProvider provideItems
    */
+  #[DataProvider('provideItems')]
   public function testToGenerator(array $items): void {
     $buf = new LargeArrayBuffer();
     foreach($items as $item){