Adhere to DCM 1.36.0

dcm_global.yaml

@@ -1 +1 @@
-version: "1.35.0"
+version: "1.36.0"

packages/netglade_analysis/CHANGELOG.md

@@ -1,3 +1,15 @@
+## 22.0.0
+- Adhere to DCM 1.36.0:
+  - avoid-unassigned-local-variable
+  - avoid-unnecessary-parentheses
+  - prefer-non-nulls
+  - prefer-correct-static-icon-provider
+  - add-equatable-props
+  - avoid-implementation-in-mocks
+  - pass-mock-object
+  - prefer-correct-any-matcher
+  - use-then-answer
+
 ## 21.0.0
 - Adhere to DCM 1.34.0 and 1.35.0:
   - Add avoid-complex-conditions

packages/netglade_analysis/README.md

@@ -23,7 +23,7 @@ To use the lints, add as a dev dependency in your `pubspec.yaml`:
 
 ```yaml
 dev_dependencies:
-  netglade_analysis: ^21.0.0
+  netglade_analysis: ^22.0.0
 ```
 
 Then, add an include in `analysis_options.yaml`:

packages/netglade_analysis/lib/dcm.yaml

@@ -171,12 +171,14 @@ dart_code_metrics:
     - avoid-suspicious-super-overrides
     - avoid-throw-in-catch-block
     - avoid-throw-objects-without-tostring
+    # - avoid-throw # for now we just manually check this
     - avoid-top-level-members-in-tests:
         include:
           - test/**/*_test.dart
     # - avoid-type-casts # needed when working with JSONs
     - avoid-unassigned-fields
     - avoid-unassigned-late-fields
+    - avoid-unassigned-local-variable
     - avoid-unassigned-stream-subscriptions
     - avoid-uncaught-future-errors
     - avoid-unconditional-break
@@ -205,6 +207,7 @@ dart_code_metrics:
     - avoid-unnecessary-nullable-parameters
     - avoid-unnecessary-nullable-return-type
     - avoid-unnecessary-overrides
+    - avoid-unnecessary-parentheses
     - avoid-unnecessary-patterns
     - avoid-unnecessary-reassignment
     - avoid-unnecessary-return
@@ -407,6 +410,7 @@ dart_code_metrics:
     # - prefer-named-imports # * OK, we just don't have global config
     - prefer-named-parameters:
         max-number: 2
+    - prefer-non-nulls
     - prefer-null-aware-elements
     - prefer-null-aware-spread
     - prefer-overriding-parent-equality
@@ -467,6 +471,7 @@ dart_code_metrics:
     # - add-copy-with # * OK, we just don't have global config
     - always-remove-listener
     - avoid-border-all
+    # - avoid-disposing-late-fields # not sure it works for us
     - avoid-empty-setstate
     - avoid-expanded-as-spacer
     - avoid-flexible-outside-flex
@@ -504,6 +509,7 @@ dart_code_metrics:
     - prefer-container:
         min-sequence: 2
     - prefer-correct-edge-insets-constructor
+    - prefer-correct-static-icon-provider
     - prefer-dedicated-media-query-methods
     - prefer-define-hero-tag
     - prefer-extracting-callbacks
@@ -549,8 +555,8 @@ dart_code_metrics:
     - avoid-passing-build-context-to-blocs
     - avoid-returning-value-from-cubit-methods
     - check-is-not-closed-after-async-gap
-        # additional-methods:
-          # - onSafe # ? Don't put onSafe here, it automatically checks whether bloc is closed in emit
+      # additional-methods:
+      # - onSafe # ? Don't put onSafe here, it automatically checks whether bloc is closed in emit
     - emit-new-bloc-state-instances
     - handle-bloc-event-subclasses:
         additional-methods:
@@ -581,6 +587,7 @@ dart_code_metrics:
     - use-ref-read-synchronously
 
     ### Equatable
+    - add-equatable-props
     # - extend-equatable # * OK, we just don't have global config
     - list-all-equatable-fields
     - prefer-equatable-mixin
@@ -598,6 +605,12 @@ dart_code_metrics:
     ### Fake Async
     - avoid-async-callback-in-fake-async
 
+    ### Mocktail
+    - avoid-implementation-in-mocks
+    - pass-mock-object
+    - prefer-correct-any-matcher
+    - use-then-answer
+
     ### Get It
     - avoid-functions-in-register-singleton:
         severity: error
@@ -655,7 +668,7 @@ dart_code_metrics:
     - prefer-publish-to-none
     - prefer-semver-version
     - pubspec-ordering
-  
+
   metrics:
     # Function / Method Metrics
     cyclomatic-complexity: 20

packages/netglade_analysis/pubspec.yaml

@@ -1,7 +1,7 @@
 name: netglade_analysis
 resolution: workspace
 description: Lint rules for Dart and Flutter used internally at netglade.
-version: 21.0.0
+version: 22.0.0
 repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
 issue_tracker: https://github.com/netglade/flutter_core/issues
 homepage: https://github.com/netglade/flutter_core

packages/netglade_flutter_utils/example/pubspec.yaml

@@ -10,7 +10,7 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  netglade_analysis: ^21.0.0
+  netglade_analysis: ^22.0.0
   netglade_flutter_utils:
     path: ..
 

packages/netglade_flutter_utils/pubspec.yaml

@@ -20,7 +20,7 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
   mocktail: ^1.0.0
-  netglade_analysis: ^21.0.0
+  netglade_analysis: ^22.0.0
   test: ^1.25.8
 
 flutter:

packages/netglade_utils/example/pubspec.yaml

@@ -7,6 +7,6 @@ environment:
   sdk: ^3.10.0
 
 dependencies:
-  netglade_analysis: ^21.0.0
+  netglade_analysis: ^22.0.0
   netglade_utils:
     path: ..

packages/netglade_utils/pubspec.yaml

@@ -18,5 +18,5 @@ dependencies:
   mocktail: ^1.0.0
 
 dev_dependencies:
-  netglade_analysis: ^21.0.0
+  netglade_analysis: ^22.0.0
   test: ^1.25.2