Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ COPY --from=composer:2@sha256:1c62c57bb5228569034b7b4d1415b17ba6b731619f7de226ea
COPY --chown=phpbu:phpbu app/full/composer.json ./composer.json
COPY --chown=phpbu:phpbu app/full/composer.lock ./composer.lock

# Install dependencies with optimization
# Install dependencies with optimization.
# NOTE: composer warns that microsoft/azure-storage-blob is abandoned. This is
# intentional and accepted — phpbu's Azure Blob sync adapter is hardwired to that
# SDK and Microsoft shipped no replacement. See README "Supported Sync Targets".
RUN composer install \
--no-ansi \
--no-dev \
Expand Down
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,23 @@ services:
|--------|-------------|---------|
| Amazon S3 / S3-compatible | `aws/aws-sdk-php` | **full** |
| Google Cloud Storage | `google/cloud-storage` | **full** |
| Azure Blob Storage | `microsoft/azure-storage-blob` | **full** |
| Azure Blob Storage | `microsoft/azure-storage-blob` ⚠️ | **full** |
| SFTP | `phpseclib/phpseclib` | **full** |
| FTP | `sebastianfeldmann/ftp` | **full** |
| Dropbox | `kunalvarma05/dropbox-php-sdk` | **full** |
| Rsync | system binary | **full** |
| Local/NFS | - | minimal, full |

> ⚠️ **`microsoft/azure-storage-blob` is abandoned upstream.** Microsoft retired the
> `microsoft/azure-storage-*` libraries with no Composer replacement. We keep the package
> intentionally because phpbu's Azure Blob sync adapter
> ([`Backup\Sync\AzureBlob`](https://github.com/sebastianfeldmann/phpbu/blob/master/src/Backup/Sync/AzureBlob.php))
> is hardwired to its `MicrosoftAzure\Storage\Blob\BlobRestProxy` client — dropping it would
> remove Azure sync from the full image. The package still works and its only moving security
> surface (Guzzle) is patched via Dependabot. A migration to the maintained `azure-oss/storage`
> SDK has to happen in phpbu upstream first; tracked there. If you don't sync to Azure, use the
> `minimal` image, which doesn't carry this dependency.
Comment on lines +256 to +258

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase "tracked there" is plain text and lacks a hyperlink. Since the upstream issue is being drafted, it would be highly beneficial to turn this into an active hyperlink to the phpbu issues page (or the specific issue once created) so users can easily navigate to and track the progress.

For example:

> surface (Guzzle) is patched via Dependabot. A migration to the maintained `azure-oss/storage`
> SDK has to happen in phpbu upstream first; [tracked upstream](https://github.com/sebastianfeldmann/phpbu/issues). If you don't sync to Azure, use the
> `minimal` image, which doesn't carry this dependency.


### Additional Tools (full variant only)

| Tool | Purpose |
Expand Down