SmartObject: @property with whitespace or newlines inside the type is silently ignored#339
Open
mabar wants to merge 2 commits into
Open
SmartObject: @property with whitespace or newlines inside the type is silently ignored#339mabar wants to merge 2 commits into
mabar wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectHelpers::getMagicProperties()does not recognize a@propertyannotation when the type contains whitespace, which is common with generics and array shapes. The properties are silently dropped and lead to member access exception at runtime. It bit me while adding types to an old codebaseFixed regex now parses the types with newlines and whitespace properly and with no backtracking
I have also noticed the same issue in strictGet/strictSet, "did you mean" hint was missing. Fixed in second commit.